• Tom Lane's avatar
    Fix hash table size estimation error in choose_hashed_distinct(). · 34548763
    Tom Lane authored
    We should account for the per-group hashtable entry overhead when
    considering whether to use a hash aggregate to implement DISTINCT.  The
    comparable logic in choose_hashed_grouping() gets this right, but I think
    I omitted it here in the mistaken belief that there would be no overhead
    if there were no aggregate functions to be evaluated.  This can result in
    more than 2X underestimate of the hash table size, if the tuples being
    aggregated aren't very wide.  Per report from Tomas Vondra.
    
    This bug is of long standing, but per discussion we'll only back-patch into
    9.3.  Changing the estimation behavior in stable branches seems to carry too
    much risk of destabilizing plan choices for already-tuned applications.
    34548763
planner.c 116 KB