• Fujii Masao's avatar
    Make concurrent refresh check early that there is a unique index on matview. · 31b6606c
    Fujii Masao authored
    In REFRESH MATERIALIZED VIEW command, CONCURRENTLY option is only
    allowed if there is at least one unique index with no WHERE clause on
    one or more columns of the matview. Previously, concurrent refresh
    checked the existence of a unique index on the matview after filling
    the data to new snapshot, i.e., after calling refresh_matview_datafill().
    So, when there was no unique index, we could need to wait a long time
    before we detected that and got the error. It was a waste of time.
    
    To eliminate such wasting time, this commit changes concurrent refresh
    so that it checks the existence of a unique index at the beginning of
    the refresh operation, i.e., before starting any time-consuming jobs.
    If CONCURRENTLY option is not allowed due to lack of a unique index,
    concurrent refresh can immediately detect it and emit an error.
    
    Author: Masahiko Sawada
    Reviewed-by: Michael Paquier, Fujii Masao
    31b6606c
matview.c 26.3 KB