• Tom Lane's avatar
    Use improved vsnprintf calling logic in more places. · 3147acd6
    Tom Lane authored
    When we are using a C99-compliant vsnprintf implementation (which should be
    most places, these days) it is worth the trouble to make use of its report
    of how large the buffer needs to be to succeed.  This patch adjusts
    stringinfo.c and some miscellaneous usages in pg_dump to do that, relying
    on the logic recently added in libpgcommon's psprintf.c.  Since these
    places want to know the number of bytes written once we succeed, modify the
    API of pvsnprintf() to report that.
    
    There remains near-duplicate logic in pqexpbuffer.c, but since that code
    is in libpq, psprintf.c's approach of exit()-on-error isn't appropriate
    for use there.  Also note that I didn't bother touching the multitude
    of places that call (v)snprintf without any attempt to provide a resizable
    buffer.
    
    Release-note-worthy incompatibility: the API of appendStringInfoVA()
    changed.  If there's any third-party code that's calling that directly,
    it will need tweaking along the same lines as in this patch.
    
    David Rowley and Tom Lane
    3147acd6
psprintf.c 5.19 KB