• David Rowley's avatar
    Attempt to fix unstable regression tests · 2dc16efe
    David Rowley authored
    b07642db added code to trigger autovacuums based on the number of
    inserts into a table. This seems to have caused some regression test
    results to destabilize. I suspect this is due to autovacuum triggering a
    vacuum sometime after the test's ANALYZE run and perhaps reltuples is
    ending up being set to a slightly different value as a result.
    
    Attempt to resolve this by running a VACUUM ANALYZE on the affected table
    instead of just ANALYZE. pg_class.reltuples will still get set to whatever
    ANALYZE chooses but we should no longer get the proceeding autovacuum
    overriding that.
    
    The overhead this adds to each test's runtime seems small enough not to
    worry about. I measure 3-4% on stats_ext and can't measure any change in
    partition_aggregate.
    
    I'm unable to recreate the issue locally, so this is a bit of a blind
    fix.
    
    Discussion: https://postgr.es/m/CAApHDvpWmpqYrKwwDQyeDq8dAyK7GMNaxDhrG69CkSuXoEg%2BVg%40mail.gmail.com
    2dc16efe
stats_ext.out 51.9 KB