• Tom Lane's avatar
    Don't Insert() a VFD entry until it's fully built. · 2bd49b49
    Tom Lane authored
    Otherwise, if FDDEBUG is enabled, the debugging output fails because
    it tries to read the fileName, which isn't set up yet (and should in
    fact always be NULL).
    
    AFAICT, this has been wrong since Berkeley.  Before 96bf88d5,
    it would accidentally fail to crash on platforms where snprintf()
    is forgiving about being passed a NULL pointer for %s; but the
    file name intended to be included in the debug output wouldn't
    ever have shown up.
    
    Report and fix by Greg Nancarrow.  Although this is only visibly
    broken in custom-made builds, it still seems worth back-patching
    to all supported branches, as the FDDEBUG code is pretty useless
    as it stands.
    
    Discussion: https://postgr.es/m/CAJcOf-cUDgm9qYtC_B6XrC6MktMPNRby2p61EtSGZKnfotMArw@mail.gmail.com
    2bd49b49
fd.c 95.2 KB