• Tom Lane's avatar
    Account better for planning cost when choosing whether to use custom plans. · 2aac3399
    Tom Lane authored
    The previous coding in plancache.c essentially used 10% of the estimated
    runtime as its cost estimate for planning.  This can be pretty bogus,
    especially when the estimated runtime is very small, such as in a simple
    expression plan created by plpgsql, or a simple INSERT ... VALUES.
    
    While we don't have a really good handle on how planning time compares
    to runtime, it seems reasonable to use an estimate based on the number of
    relations referenced in the query, with a rather large multiplier.  This
    patch uses 1000 * cpu_operator_cost * (nrelations + 1), so that even a
    trivial query will be charged 1000 * cpu_operator_cost for planning.
    This should address the problem reported by Marc Cousin and others that
    9.2 and up prefer custom plans in cases where the planning time greatly
    exceeds what can be saved.
    2aac3399
plancache.c 58.3 KB