• Michael Paquier's avatar
    pgcrypto: Detect errors with EVP calls from OpenSSL · 28d1601a
    Michael Paquier authored
    The following routines are called within pgcrypto when handling digests
    but there were no checks for failures:
    - EVP_MD_CTX_size (can fail with -1 as of 3.0.0)
    - EVP_MD_CTX_block_size (can fail with -1 as of 3.0.0)
    - EVP_DigestInit_ex
    - EVP_DigestUpdate
    - EVP_DigestFinal_ex
    
    A set of elog(ERROR) is added by this commit to detect such failures,
    that should never happen except in the event of a processing failure
    internal to OpenSSL.
    
    Note that it would be possible to use ERR_reason_error_string() to get
    more context about such errors, but these refer mainly to the internals
    of OpenSSL, so it is not really obvious how useful that would be.  This
    is left out for simplicity.
    
    Per report from Coverity.  Thanks to Tom Lane for the discussion.
    
    Backpatch-through: 9.5
    28d1601a
openssl.c 17.1 KB