• Tom Lane's avatar
    Improve consistency of parsing of psql's magic variables. · 28551797
    Tom Lane authored
    For simple boolean variables such as ON_ERROR_STOP, psql has for a long
    time recognized variant spellings of "on" and "off" (such as "1"/"0"),
    and it also made a point of warning you if you'd misspelled the setting.
    But these conveniences did not exist for other keyword-valued variables.
    In particular, though ECHO_HIDDEN and ON_ERROR_ROLLBACK include "on" and
    "off" as possible values, none of the alternative spellings for those were
    recognized; and to make matters worse the code would just silently assume
    "on" was meant for any unrecognized spelling.  Several people have reported
    getting bitten by this, so let's fix it.  In detail, this patch:
    
    * Allows all spellings recognized by ParseVariableBool() for ECHO_HIDDEN
    and ON_ERROR_ROLLBACK.
    
    * Reports a warning for unrecognized values for COMP_KEYWORD_CASE, ECHO,
    ECHO_HIDDEN, HISTCONTROL, ON_ERROR_ROLLBACK, and VERBOSITY.
    
    * Recognizes all values for all these variables case-insensitively;
    previously there was a mishmash of case-sensitive and case-insensitive
    behaviors.
    
    Back-patch to all supported branches.  There is a small risk of breaking
    existing scripts that were accidentally failing to malfunction; but the
    consensus is that the chance of detecting real problems and preventing
    future mistakes outweighs this.
    28551797
variables.h 1.67 KB