• Tom Lane's avatar
    Check block number against the correct fork in get_raw_page(). · 27cef0a5
    Tom Lane authored
    get_raw_page tried to validate the supplied block number against
    RelationGetNumberOfBlocks(), which of course is only right when
    accessing the main fork.  In most cases, the main fork is longer
    than the others, so that the check was too weak (allowing a
    lower-level error to be reported, but no real harm to be done).
    However, very small tables could have an FSM larger than their heap,
    in which case the mistake prevented access to some FSM pages.
    Per report from Torsten Foertsch.
    
    In passing, make the bad-block-number error into an ereport not elog
    (since it's certainly not an internal error); and fix sloppily
    maintained comment for RelationGetNumberOfBlocksInFork.
    
    This has been wrong since we invented relation forks, so back-patch
    to all supported branches.
    27cef0a5
bufmgr.c 93.4 KB