• Michael Paquier's avatar
    Adjust comments of CheckRelationTableSpaceMove() and SetRelationTableSpace() · 24843297
    Michael Paquier authored
    4c9c359d, that introduced those two functions, has been overoptimistic on
    the point that only ShareUpdateExclusiveLock would be required when
    moving a relation to a new tablespace.  AccessExclusiveLock is a
    requirement, but ShareUpdateExclusiveLock may be used under specific
    conditions like REINDEX CONCURRENTLY where waits on past transactions
    make the operation safe even with a lower-level lock.  The current code
    does only the former, so update the existing comments to reflect that.
    
    Once a REINDEX (TABLESPACE) is introduced, those comments would require
    an extra refresh to mention their new use case.
    
    While on it, fix an incorrect variable name.
    
    Per discussion with Álvaro Herrera.
    
    Discussion: https://postgr.es/m/20210127140741.GA14174@alvherre.pgsql
    24843297
tablecmds.c 543 KB