• Tom Lane's avatar
    Rename MaxTupleSize to MaxHeapTupleSize to clarify that it's not meant to · 23c4978e
    Tom Lane authored
    describe the maximum size of index tuples (which is typically AM-dependent
    anyway); and consequently remove the bogus deduction for "special space"
    that was built into it.
    
    Adjust TOAST_TUPLE_THRESHOLD and TOAST_MAX_CHUNK_SIZE to avoid wasting two
    bytes per toast chunk, and to ensure that the calculation correctly tracks any
    future changes in page header size.  The computation had been inaccurate in a
    way that didn't cause any harm except space wastage, but future changes could
    have broken it more drastically.
    
    Fix the calculation of BTMaxItemSize, which was formerly computed as 1 byte
    more than it could safely be.  This didn't cause any harm in practice because
    it's only compared against maxalign'd lengths, but future changes in the size
    of page headers or btree special space could have exposed the problem.
    
    initdb forced because of change in TOAST_MAX_CHUNK_SIZE, which alters the
    storage of toast tables.
    23c4978e
vacuum.c 99.7 KB