• Tom Lane's avatar
    Centralize libpq's low-level code for dropping a connection. · 210eb9b7
    Tom Lane authored
    Create an internal function pqDropConnection that does the physical socket
    close and cleans up closely-associated state.  This removes a bunch of ad
    hoc, not always consistent closure code.  The ulterior motive is to have a
    single place to wait for a spawned child backend to exit, but this seems
    like good cleanup even if that never happens.
    
    I went back and forth on whether to include "conn->status = CONNECTION_BAD"
    in pqDropConnection's actions, but for the moment decided not to.  Only a
    minority of the call sites actually want that, and in any case it's
    arguable that conn->status is slightly higher-level state, and thus not
    part of this function's purview.
    210eb9b7
fe-connect.c 136 KB