• Alvaro Herrera's avatar
    Fix thinko in estimate_num_groups · 1f171a18
    Alvaro Herrera authored
    The code for the reworked n-distinct estimation on commit 7b504eb2 was
    written differently in a previous version of the patch, prior to commit;
    on rewriting it, we missed updating an initializer.  This caused the
    code to (mistakenly) apply a fudge factor even in the case where a
    single value is applied, leading to incorrect results.
    
    This means that the 'relvarcount' variable name is now wrong.  Add a
    comment to try and make the situation clearer, and remove an incorrect
    comment I added.
    
    Problem noticed, and code patch, by Tomas Vondra.  Additional commentary
    by Álvaro.
    1f171a18
selfuncs.c 225 KB