• Tom Lane's avatar
    Fix ecpg's mishandling of B'...' and X'...' literals. · 1e3868ab
    Tom Lane authored
    These were broken in multiple ways:
    
    * The xbstart and xhstart lexer actions neglected to set
    "state_before_str_start" before transitioning to the xb/xh states,
    thus possibly resulting in "internal error: unreachable state" later.
    
    * The test for valid string contents at the end of xb state was flat out
    wrong, as it accounted incorrectly for the "b" prefix that the xbstart
    action had injected.  Meanwhile, the xh state had no such check at all.
    
    * The generated literal value failed to include any quote marks.
    
    * The grammar did the wrong thing anyway, typically ignoring the
    literal value and emitting something else, since BCONST and XCONST
    tokens were handled randomly differently from SCONST tokens.
    
    The first of these problems is evidently an oversight in commit
    7f380c59, but the others seem to be very ancient.  The lack of
    complaints shows that ECPG users aren't using these syntaxes much
    (although I do vaguely remember one previous complaint).
    
    As written, this patch is dependent on 7f380c59, so it can't go
    back further than v13.  Given the shortage of complaints, I'm not
    excited about adapting the patch to prior branches.
    
    Report and patch by Shenhao Wang (test case adjusted by me)
    
    Discussion: https://postgr.es/m/d6402f1bacb74ecba22ef715dbba17fd@G08CNEXMBPEKD06.g08.fujitsu.local
    1e3868ab
pgc.l 44.4 KB