• Fujii Masao's avatar
    Fix bug that causes to report waiting in PS display twice, in hot standby. · 17d3fcdc
    Fujii Masao authored
    Previously "waiting" could appear twice via PS in case of lock conflict
    in hot standby mode. Specifically this issue happend when the delay
    in WAL application determined by max_standby_archive_delay and
    max_standby_streaming_delay had passed but it took more than 500 msec
    to cancel all the conflicting transactions. Especially we can observe this
    easily by setting those delay parameters to -1.
    
    The cause of this issue was that WaitOnLock() and
    ResolveRecoveryConflictWithVirtualXIDs() added "waiting" to
    the process title in that case. This commit prevents
    ResolveRecoveryConflictWithVirtualXIDs() from reporting waiting
    in case of lock conflict, to fix the bug.
    
    Back-patch to all back branches.
    
    Author: Masahiko Sawada
    Reviewed-by: Fujii Masao
    Discussion: https://postgr.es/m/CA+fd4k4mXWTwfQLS3RPwGr4xnfAEs1ysFfgYHvmmoUgv6Zxvmg@mail.gmail.com
    17d3fcdc
standby.c 34.8 KB