• Tom Lane's avatar
    Remove obsolete replication settings within TAP tests. · 151c0c5f
    Tom Lane authored
    PostgresNode.pm set "max_wal_senders = 5" for replication testing,
    but this seems to be slightly too low for our current test suite.
    Slower buildfarm members frequently report "number of requested standby
    connections exceeds max_wal_senders" failures, due to old walsenders
    not exiting instantaneously.  Usually, the test does not fail overall
    because of automatic walreceiver restart, but sometimes the failure
    becomes visible; and in any case such retries slow down the test.
    
    That value came in with commit 89ac7004, but was soon obsoleted by
    f6d6d292, which raised the built-in default from zero to 10; so that
    PostgresNode.pm is actually setting it to less than the conservative
    built-in default.  That seems pretty pointless, so let's remove the
    special setting and let the default prevail, in hopes of making
    the TAP tests more robust.
    
    Likewise, the setting "max_replication_slots = 5" is obsolete and
    can be removed.
    
    While here, reverse-engineer a comment about why we're choosing
    less-than-default values for some other settings.
    
    (Note: before v12, max_wal_senders counted against max_connections
    so that the latter setting also needs some fiddling with.)
    
    Back-patch to v10 where the subscription tests were added.
    It's likely that the older branches aren't pushing the boundaries
    of max_wal_senders, but I'm disinclined to spend time trying to
    figure out exactly when it started to be a problem.
    
    Discussion: https://postgr.es/m/723911.1601417626@sss.pgh.pa.us
    151c0c5f
PostgresNode.pm 50.6 KB