• Tom Lane's avatar
    Fix portability bugs in use of credentials control messages for peer auth. · 13c00ae8
    Tom Lane authored
    Even though our existing code for handling credentials control messages has
    been basically unchanged since 2001, it was fundamentally wrong: it did not
    ensure proper alignment of the supplied buffer, and it was calculating
    buffer sizes and message sizes incorrectly.  This led to failures on
    platforms where alignment padding is relevant, for instance FreeBSD on
    64-bit platforms, as seen in a recent Debian bug report passed on by
    Martin Pitt (http://bugs.debian.org//cgi-bin/bugreport.cgi?bug=612888).
    
    Rewrite to do the message-whacking using the macros specified in RFC 2292,
    following a suggestion from Theo de Raadt in that thread.  Tested by me
    on Debian/kFreeBSD-amd64; since OpenBSD and NetBSD document the identical
    CMSG API, it should work there too.
    
    Back-patch to all supported branches.
    13c00ae8
fe-auth.c 26.5 KB