• Tom Lane's avatar
    Fix plancache refcount leak after error in ExecuteQuery. · 131ea3e9
    Tom Lane authored
    When stuffing a plan from the plancache into a Portal, one is
    not supposed to risk throwing an error between GetCachedPlan and
    PortalDefineQuery; if that happens, the plan refcount incremented
    by GetCachedPlan will be leaked.  I managed to break this rule
    while refactoring code in 9dbf2b7d.  There is no visible
    consequence other than some memory leakage, and since nobody is
    very likely to trigger the relevant error conditions many times
    in a row, it's not surprising we haven't noticed.  Nonetheless,
    it's a bug, so rearrange the order of operations to remove the
    hazard.
    
    Noted on the way to looking for a better fix for bug #17053.
    This mistake is pretty old, so back-patch to all supported
    branches.
    131ea3e9
prepare.c 22.2 KB