• Michael Paquier's avatar
    Simplify TAP tests of kerberos with expected log file contents · 11e1577a
    Michael Paquier authored
    The TAP tests of kerberos rely on the logs generated by the backend to
    check various connection scenarios.  In order to make sure that a given
    test does not overlap with the log contents generated by a previous
    test, the test suite relied on a logic with the logging collector and a
    rotation of the log files to ensure the uniqueness of the log generated
    with a wait phase.
    
    Parsing the log contents for expected patterns is a problem that has
    been solved in a simpler way by PostgresNode::issues_sql_like() where
    the log file is truncated before checking for the contents generated,
    with the backend sending its output to a log file given by pg_ctl
    instead.  This commit switches the kerberos test suite to use such a
    method, removing any wait phase and simplifying the whole logic,
    resulting in less code.  If a failure happens in the tests, the contents
    of the logs are still showed to the user at the moment of the failure
    thanks to like(), so this has no impact on debugging capabilities.
    
    I have bumped into this issue while reviewing a different patch set
    aiming at extending the kerberos test suite to check for multiple
    log patterns instead of one now.
    
    Author: Michael Paquier
    Reviewed-by: Stephen Frost, Bharath Rupireddy
    Discussion: https://postgr.es/m/YFXcq2vBTDGQVBNC@paquier.xyz
    11e1577a
001_auth.pl 10.5 KB