• Tom Lane's avatar
    Simplify loop logic in nodeIncrementalSort.c. · 0e529031
    Tom Lane authored
    The inner loop in switchToPresortedPrefixMode() can be implemented
    as a conventional integer-counter for() loop, removing a couple of
    redundant boolean state variables.  The old logic here was a remnant
    of earlier development, but as things now stand there's no reason
    for extra complexity.
    
    Also, annotate the test case added by 82e0e293 to explain why it
    manages to hit the corner case fixed in that commit, and add an
    EXPLAIN to verify that it's creating an incremental-sort plan.
    
    Back-patch to v13, like the previous patch.
    
    James Coleman and Tom Lane
    
    Discussion: https://postgr.es/m/16846-ae49f51ac379a4cb@postgresql.org
    0e529031
incremental_sort.sql 12.1 KB