• David Rowley's avatar
    Make EXPLAIN ANALYZE of HashAgg more similar to Hash Join · 0e3e1c4e
    David Rowley authored
    There were various unnecessary differences between Hash Agg's EXPLAIN
    ANALYZE output and Hash Join's.  Here we modify the Hash Agg output so
    that it's better aligned to Hash Join's.
    
    The following changes have been made:
    1. Start batches counter at 1 instead of 0.
    2. Always display the "Batches" property, even when we didn't spill to
       disk.
    3. Use the text "Batches" instead of "HashAgg Batches" for text format.
    4. Use the text "Memory Usage" instead of "Peak Memory Usage" for text
       format.
    5. Include "Batches" before "Memory Usage" in both text and non-text
       formats.
    
    In passing also modify the "Planned Partitions" property so that we show
    it regardless of if the value is 0 or not for non-text EXPLAIN formats.
    This was pointed out by Justin Pryzby and probably should have been part
    of 40efbf87.
    
    Reviewed-by: Justin Pryzby, Jeff Davis
    Discussion: https://postgr.es/m/CAApHDvrshRnA6C0VFnu7Fb9TVvgGo80PUMm5+2DiaS1gEkPvtw@mail.gmail.com
    Backpatch-through: 13, where HashAgg batching was introduced
    0e3e1c4e
nodeAgg.c 155 KB