• Michael Paquier's avatar
    Move some client-specific routines from SSLServer to PostgresNode · 0d1a3343
    Michael Paquier authored
    test_connect_ok() and test_connect_fails() have always been part of the
    SSL tests, and check if a connection to the backend should work or not,
    and there are sanity checks done on specific error patterns dropped by
    libpq if the connection fails.
    
    This was fundamentally wrong on two aspects.  First, SSLServer.pm works
    mostly on setting up and changing the SSL configuration of a
    PostgresNode, and has really nothing to do with the client.  Second,
    the situation became worse in light of b34ca595, where the SSL tests
    would finish by using a psql command that may not come from the same
    installation as the node set up.
    
    This commit moves those client routines into PostgresNode, making easier
    the refactoring of SSLServer to become more SSL-implementation aware.
    This can also be reused by the ldap, kerberos and authentication test
    suites for connection checks, and a follow-up patch should extend those
    interfaces to match with backend log patterns.
    
    Author: Michael Paquier
    Reviewed-by: Andrew Dunstan, Daniel Gustafsson, Álvaro Herrera
    Discussion: https://postgr.es/m/YGLKNBf9zyh6+WSt@paquier.xyz
    0d1a3343
PostgresNode.pm 58.3 KB