• Michael Paquier's avatar
    Fix unexpected error messages for various flavors of ALTER TABLE · 0c83eb2e
    Michael Paquier authored
    Some commands of ALTER TABLE could fail with the following error:
    ERROR:  "tab" is of the wrong type
    
    This error is unexpected, as all the code paths leading to
    ATWrongRelkindError() should use a supported set of relkinds to generate
    correct error messages.  This commit closes the gap with such mistakes,
    by adding all the missing relkind combinations.  Tests are added to
    check all the problems found.  Note that some combinations are not used,
    but these are left around as it could have an impact on applications
    relying on this code.
    
    2ed532e has done a much larger refactoring on HEAD to make such error
    messages easier to manage in the long-term, so nothing is needed there.
    
    Author: Kyotaro Horiguchi
    Reviewed-by: Peter Eisentraut, Ahsan Hadi, Michael Paquier
    Discussion: https://postgr.es/m/20210216.181415.368926598204753659.horikyota.ntt@gmail.com
    Backpatch-through: 11
    0c83eb2e
alter_table.sql 108 KB