• Peter Eisentraut's avatar
    Refactor new file permission handling · 0c5803b4
    Peter Eisentraut authored
    The file handling functions from fd.c were called with a diverse mix of
    notations for the file permissions when they were opening new files.
    Almost all files created by the server should have the same permissions
    set.  So change the API so that e.g. OpenTransientFile() automatically
    uses the standard permissions set, and OpenTransientFilePerm() is a new
    function that takes an explicit permissions set for the few cases where
    it is needed.  This also saves an unnecessary argument for call sites
    that are just opening an existing file.
    
    While we're reviewing these APIs, get rid of the FileName typedef and
    use the standard const char * for the file name and mode_t for the file
    mode.  This makes these functions match other file handling functions
    and removes an unnecessary layer of mysteriousness.  We can also get rid
    of a few casts that way.
    
    Author: David Steele <david@pgmasters.net>
    0c5803b4
walsender.c 98.2 KB