• Tom Lane's avatar
    Add comments warning against generalizing default_with_oids. · 0bd11d97
    Tom Lane authored
    pg_dump has historically assumed that default_with_oids affects only plain
    tables and not other relkinds.  Conceivably we could make it apply to some
    newly invented relkind if we did so from the get-go, but changing the
    behavior for existing object types will break existing dump scripts.
    Add code comments warning about this interaction.
    
    Also, make sure that default_with_oids doesn't cause parse_utilcmd.c to
    think that CREATE FOREIGN TABLE will create an OID column.  I think this is
    only a latent bug right now, since we don't allow UNIQUE/PKEY constraints
    in CREATE FOREIGN TABLE, but it's better to be consistent and future-proof.
    0bd11d97
parse_utilcmd.c 85.5 KB