• Michael Paquier's avatar
    Allow concurrent-safe open() and fopen() in frontend code for Windows · 0ba06e0b
    Michael Paquier authored
    PostgreSQL uses a custom wrapper for open() and fopen() which is
    concurrent-safe, allowing multiple processes to open and work on the
    same file.  This has a couple of advantages:
    - pg_test_fsync does not handle O_DSYNC correctly otherwise, leading to
    false claims that disks are unsafe.
    - TAP tests can run into race conditions when a postmaster and pg_ctl
    open postmaster.pid, fixing some random failures in the buildfam.
    
    pg_upgrade is one frontend tool using workarounds to bypass file locking
    issues with the log files it generates, however the interactions with
    pg_ctl are proving to be tedious to get rid of, so this is left for
    later.
    
    Author: Laurenz Albe
    Reviewed-by: Michael Paquier, Kuntal Ghosh
    Discussion: https://postgr.es/m/1527846213.2475.31.camel@cybertec.at
    Discussion: https://postgr.es/m/16922.1520722108@sss.pgh.pa.us
    0ba06e0b
initdb.c 88.7 KB