• Tom Lane's avatar
    Fix unportable use of getnameinfo() in pg_hba_file_rules view. · 0a4b3403
    Tom Lane authored
    fill_hba_line() thought it could get away with passing sizeof(struct
    sockaddr_storage) rather than the actual addrlen previously returned
    by getaddrinfo().  While that appears to work on many platforms,
    it does not work on FreeBSD 11: you get back a failure, which leads
    to the view showing NULL for the address and netmask columns in all
    rows.  The POSIX spec for getnameinfo() is pretty clearly on
    FreeBSD's side here: you should pass the actual address length.
    So it seems plausible that there are other platforms where this
    coding also fails, and we just hadn't noticed.
    
    Also, IMO the fact that getnameinfo() failure leads to a NULL output
    is pretty bogus in itself.  Our pg_getnameinfo_all() wrapper is
    careful to emit "???" on failure, and we should use that in such
    cases.  NULL should only be emitted in rows that don't have IP
    addresses.
    
    Per bug #16695 from Peter Vandivier.  Back-patch to v10 where this
    code was added.
    
    Discussion: https://postgr.es/m/16695-a665558e2f630be7@postgresql.org
    0a4b3403
hba.c 84.8 KB