• Tom Lane's avatar
    Fix some probably-minor oversights in readfuncs.c. · 09991e5a
    Tom Lane authored
    The system expects TABLEFUNC RTEs to have coltypes, coltypmods, and
    colcollations lists, but outfuncs doesn't dump them and readfuncs doesn't
    restore them.  This doesn't cause obvious failures, because the only things
    that look at those fields are expandRTE() and get_rte_attribute_type(),
    which are mostly used during parse analysis, before anything would've
    passed the parsetree through outfuncs/readfuncs.  But expandRTE() is used
    in build_physical_tlist(), which means that that function will return a
    wrong answer for a TABLEFUNC RTE that came from a view.  Very accidentally,
    this doesn't cause serious problems, because what it will return is NIL
    which callers will interpret as "couldn't build a physical tlist because
    of dropped columns".  So you still get a plan that works, though it's
    marginally less efficient than it could be.  There are also some other
    expandRTE() calls associated with transformation of whole-row Vars in
    the planner.  I have been unable to exhibit misbehavior from that, and
    it may be unreachable in any case that anyone would care about ... but
    I'm not entirely convinced, so this seems like something we should back-
    patch a fix for.  Fortunately, we can fix it without forcing a change
    of stored rules and a catversion bump, because we can just copy these
    lists from the subsidiary TableFunc object.
    
    readfuncs.c was also missing support for NamedTuplestoreScan plan nodes.
    This accidentally fails to break parallel query because a query using
    a named tuplestore would never be considered parallel-safe anyway.
    However, project policy since parallel query came in is that all plan
    node types should have outfuncs/readfuncs support, so this is clearly
    an oversight that should be repaired.
    
    Noted while fooling around with a patch to test outfuncs/readfuncs more
    thoroughly.  That exposed some other issues too, but these are the only
    ones that seem worth back-patching.
    
    Back-patch to v10 where both of these features came in.
    
    Discussion: https://postgr.es/m/17114.1537138992@sss.pgh.pa.us
    09991e5a
parsenodes.h 118 KB