• Alvaro Herrera's avatar
    Set wal_receiver_create_temp_slot PGC_POSTMASTER · 092c6936
    Alvaro Herrera authored
    Commit 32973082 gave walreceiver the ability to create and use a
    temporary replication slot, and made it controllable by a GUC (enabled
    by default) that can be changed with SIGHUP.  That's useful but has two
    problems: one, it's possible to cause the origin server to fill its disk
    if the slot doesn't advance in time; and also there's a disconnect
    between state passed down via the startup process and GUCs that
    walreceiver reads directly.
    
    We handle the first problem by setting the option to disabled by
    default.  If the user enables it, its on their head to make sure that
    disk doesn't fill up.
    
    We handle the second problem by passing the flag via startup rather than
    having walreceiver acquire it directly, and making it PGC_POSTMASTER
    (which ensures a walreceiver always has the fresh value).  A future
    commit can relax this (to PGC_SIGHUP again) by having the startup
    process signal walreceiver to shutdown whenever the value changes.
    
    Author: Sergei Kornilov <sk@zsrv.org>
    Reviewed-by: default avatarMichael Paquier <michael@paquier.xyz>
    Reviewed-by: default avatarÁlvaro Herrera <alvherre@alvh.no-ip.org>
    Discussion: https://postgr.es/m/20200122055510.GH174860@paquier.xyz
    092c6936
xlog.h 12.8 KB