• Tom Lane's avatar
    Fix subtly-wrong volatility checking in BeginCopyFrom(). · 060b22a9
    Tom Lane authored
    contain_volatile_functions() is best applied to the output of
    expression_planner(), not its input, so that insertion of function
    default arguments and constant-folding have been done.  (See comments
    at CheckMutability, for instance.)  It's perhaps unlikely that anyone
    will notice a difference in practice, but still we should do it properly.
    
    In passing, change variable type from Node* to Expr* to reduce the net
    number of casts needed.
    
    Noted while perusing uses of contain_volatile_functions().
    060b22a9
copy.c 118 KB