• Neil Conway's avatar
    Correct some code in pg_restore when reading the header of a tar archive: · 05db8b50
    Neil Conway authored
    (1) The code doesn't initialize `sum', so the initial "does the checksum
        match?" test is wrong.
    
    (2) The loop that is intended to check for a "null block" just checks
        the first byte of the tar block 512 times, rather than each of the
        512 bytes one time (!), which I'm guessing was the intent.
    
    It was only through sheer luck that this worked in the first place.
    
    Per Coverity static analysis performed by EnterpriseDB.
    05db8b50
pg_backup_tar.c 28.5 KB