• Tom Lane's avatar
    Rearrange the handling of error context reports. · 0426f349
    Tom Lane authored
    Remove the code in plpgsql that suppressed the innermost line of CONTEXT
    for messages emitted by RAISE commands.  That was never more than a quick
    backwards-compatibility hack, and it's pretty silly in cases where the
    RAISE is nested in several levels of function.  What's more, it violated
    our design theory that verbosity of error reports should be controlled
    on the client side not the server side.
    
    To alleviate the resulting noise increase, introduce a feature in libpq
    and psql whereby the CONTEXT field of messages can be suppressed, either
    always or only for non-error messages.  Printing CONTEXT for errors only
    is now their default behavior.
    
    The actual code changes here are pretty small, but the effects on the
    regression test outputs are widespread.  I had to edit some of the
    alternative expected outputs by hand; hopefully the buildfarm will soon
    find anything I fat-fingered.
    
    In passing, fix up (again) the output line counts in psql's various
    help displays.  Add some commentary about how to verify them.
    
    Pavel Stehule, reviewed by Petr Jelínek, Jeevan Chalke, and others
    0426f349
privileges.out 50.3 KB