• Tom Lane's avatar
    Fix the plpgsql memory leak exhibited in bug #4677. That leak was introduced · 03cd7571
    Tom Lane authored
    by my patch of 2007-01-28 to use per-subtransaction ExprContexts/EStates:
    since we re-prepared any expression tree when the current subtransaction ID
    changed, we'd accumulate more and more leaked expression state trees in the
    outermost subtransaction if the same function was executed at multiple levels
    of subtransaction nesting.  To fix, go back to the previous scheme where
    there was only one EState per transaction for simple plpgsql expressions.
    We really only need an ExprContext per subtransaction, not a whole EState,
    so it's possible to keep prepared expression state trees in the one EState
    throughout the transaction.  This should be more efficient as well as not
    leaking memory for cases involving lots of subtransactions.
    
    The added regression test is the case that inspired the 2007-01-28 patch in
    the first place, just to make sure we didn't go backwards.  The current
    memory leak complaint is unfortunately hard to test for in the regression
    test framework, though manual testing shows it's fixed.
    
    Although this is a pre-existing bug, I'm not back-patching because I'd like to
    see this method get some field testing first.  Consider back-patching if it
    gets through 8.4beta unscathed.
    03cd7571
plpgsql.out 113 KB