• Dean Rasheed's avatar
    Adjust the integer overflow tests in the numeric code. · 03255657
    Dean Rasheed authored
    Formerly, the numeric code tested whether an integer value of a larger
    type would fit in a smaller type by casting it to the smaller type and
    then testing if the reverse conversion produced the original value.
    That's perfectly fine, except that it caused a test failure on
    buildfarm animal castoroides, most likely due to a compiler bug.
    
    Instead, do these tests by comparing against PG_INT16/32_MIN/MAX. That
    matches existing code in other places, such as int84(), which is more
    widely tested, and so is less likely to go wrong.
    
    While at it, add regression tests covering the numeric-to-int8/4/2
    conversions, and adjust the recently added tests to the style of
    434ddfb79a (on the v11 branch) to make failures easier to diagnose.
    
    Per buildfarm via Tom Lane, reviewed by Tom Lane.
    
    Discussion: https://postgr.es/m/2394813.1628179479%40sss.pgh.pa.us
    03255657
numeric.c 275 KB