• Tom Lane's avatar
    Prevent potential overruns of fixed-size buffers. · 01824385
    Tom Lane authored
    Coverity identified a number of places in which it couldn't prove that a
    string being copied into a fixed-size buffer would fit.  We believe that
    most, perhaps all of these are in fact safe, or are copying data that is
    coming from a trusted source so that any overrun is not really a security
    issue.  Nonetheless it seems prudent to forestall any risk by using
    strlcpy() and similar functions.
    
    Fixes by Peter Eisentraut and Jozef Mlich based on Coverity reports.
    
    In addition, fix a potential null-pointer-dereference crash in
    contrib/chkpass.  The crypt(3) function is defined to return NULL on
    failure, but chkpass.c didn't check for that before using the result.
    The main practical case in which this could be an issue is if libc is
    configured to refuse to execute unapproved hashing algorithms (e.g.,
    "FIPS mode").  This ideally should've been a separate commit, but
    since it touches code adjacent to one of the buffer overrun changes,
    I included it in this commit to avoid last-minute merge issues.
    This issue was reported by Honza Horak.
    
    Security: CVE-2014-0065 for buffer overruns, CVE-2014-0066 for crypt()
    01824385
exec.c 18.8 KB