1. 25 Nov, 2011 2 commits
    • Robert Haas's avatar
      Move "hot" members of PGPROC into a separate PGXACT array. · ed0b409d
      Robert Haas authored
      This speeds up snapshot-taking and reduces ProcArrayLock contention.
      Also, the PGPROC (and PGXACT) structures used by two-phase commit are
      now allocated as part of the main array, rather than in a separate
      array, and we keep ProcArray sorted in pointer order.  These changes
      are intended to minimize the number of cache lines that must be pulled
      in to take a snapshot, and testing shows a substantial increase in
      performance on both read and write workloads at high concurrencies.
      
      Pavan Deolasee, Heikki Linnakangas, Robert Haas
      ed0b409d
    • Tom Lane's avatar
      Fix unsupported options in CREATE TABLE ... AS EXECUTE. · 9ed439a9
      Tom Lane authored
      The WITH [NO] DATA option was not supported, nor the ability to specify
      replacement column names; the former limitation wasn't even documented, as
      per recent complaint from Naoya Anzai.  Fix by moving the responsibility
      for supporting these options into the executor.  It actually takes less
      code this way ...
      
      catversion bump due to change in representation of IntoClause, which might
      affect stored rules.
      9ed439a9
  2. 24 Nov, 2011 4 commits
  3. 23 Nov, 2011 4 commits
    • Tom Lane's avatar
      Adjust range_adjacent to support different canonicalization rules. · b7056b83
      Tom Lane authored
      The original coding would not work for discrete ranges in which the
      canonicalization rule is to produce symmetric boundaries (either [] or ()
      style), as noted by Jeff Davis.  Florian Pflug pointed out that we could
      fix that by invoking the canonicalization function to see if the range
      "between" the two given ranges normalizes to empty.  This implementation
      of Florian's idea is a tad slower than the original code, but only in the
      case where there actually is a canonicalization function --- if not, it's
      essentially the same logic as before.
      b7056b83
    • Tom Lane's avatar
      Creator of a range type must have permission to call support functions. · a912a278
      Tom Lane authored
      Since range types can be created by non-superusers, we need to consider
      their permissions.  Ideally we'd check this when the type is used, not
      when it's created, but that seems like much more trouble than it's worth.
      The existing restriction that the support functions be immutable already
      prevents most cases where an unauthorized call to a function might be
      thought a security issue, and the fact that the user has no access to
      the results of the system's calls to subtype_diff closes off the other
      plausible reason for concern.  So this check is basically pro-forma,
      but let's make it anyway.
      a912a278
    • Tom Lane's avatar
      Remove user-selectable ANALYZE option for range types. · 74c1723f
      Tom Lane authored
      It's not clear that a per-datatype typanalyze function would be any more
      useful than a generic typanalyze for ranges.  What *is* clear is that
      letting unprivileged users select typanalyze functions is a crash risk or
      worse.  So remove the option from CREATE TYPE AS RANGE, and instead put in
      a generic typanalyze function for ranges.  The generic function does
      nothing as yet, but hopefully we'll improve that before 9.2 release.
      74c1723f
    • Tom Lane's avatar
      Remove zero- and one-argument range constructor functions. · df735844
      Tom Lane authored
      Per discussion, the zero-argument forms aren't really worth the catalog
      space (just write 'empty' instead).  The one-argument forms have some use,
      but they also have a serious problem with looking too much like functional
      cast notation; to the point where in many real use-cases, the parser would
      misinterpret what was wanted.
      
      Committing this as a separate patch, with the thought that we might want
      to revert part or all of it if we can think of some way around the cast
      ambiguity.
      df735844
  4. 22 Nov, 2011 5 commits
    • Tom Lane's avatar
      Improve implementation of range-contains-element tests. · cddc819e
      Tom Lane authored
      Implement these tests directly instead of constructing a singleton range
      and then applying range-contains.  This saves a range serialize/deserialize
      cycle as well as a couple of redundant bound-comparison steps, and adds
      very little code on net.
      
      Remove elem_contained_by_range from the GiST opclass: it doesn't belong
      there because there is no way to use it in an index clause (where the
      indexed column would have to be on the left).  Its commutator is in the
      opclass, and that's what counts.
      cddc819e
    • Robert Haas's avatar
      Check for INSERT privileges in SELECT INTO / CREATE TABLE AS. · f1b4aa2a
      Robert Haas authored
      In the normal course of events, this matters only if ALTER DEFAULT
      PRIVILEGES has been used to revoke default INSERT permission.  Whether
      or not the new behavior is more or less likely to be what the user wants
      when dealing only with the built-in privilege facilities is arguable,
      but it's clearly better when using a loadable module such as sepgsql
      that may use the hook in ExecCheckRTPerms to enforce additional
      permissions checks.
      
      KaiGai Kohei, reviewed by Albe Laurenz
      f1b4aa2a
    • Tom Lane's avatar
      Still more review for range-types patch. · 766948be
      Tom Lane authored
      Per discussion, relax the range input/construction rules so that the
      only hard error is lower bound > upper bound.  Cases where the lower
      bound is <= upper bound, but the range nonetheless normalizes to empty,
      are now permitted.
      
      Fix core dump in range_adjacent when bounds are infinite.  Marginal
      cleanup of regression test cases, some more code commenting.
      766948be
    • Peter Eisentraut's avatar
      Small markup and wording improvement · 024ea25c
      Peter Eisentraut authored
      024ea25c
    • Simon Riggs's avatar
      Continue to allow VACUUM to mark last block of index dirty · 2d2841a5
      Simon Riggs authored
      even when there is no work to do. Further analysis required.
      Revert of patch c1458cc4
      2d2841a5
  5. 21 Nov, 2011 3 commits
    • Tom Lane's avatar
      More code review for rangetypes patch. · a4ffcc8e
      Tom Lane authored
      Fix up some infelicitous coding in DefineRange, and add some missing error
      checks.  Rearrange operator strategy number assignments for GiST anyrange
      opclass so that they don't make such a mess of opr_sanity's table of
      operator names associated with different strategy numbers.  Assign
      hopefully-temporary selectivity estimators to range operators that didn't
      have one --- poor as the estimates are, they're still a lot better than the
      default 0.5 estimate, and they'll shut up the opr_sanity test that wants to
      see selectivity estimators on all built-in operators.
      a4ffcc8e
    • Tom Lane's avatar
      Fix citext upgrade script to update derived copies of pg_type.typcollation. · 9b97b7f8
      Tom Lane authored
      If the existing citext type has not merely been created, but used in any
      tables, then the upgrade script wasn't doing enough.  We have to update
      attcollation for each citext table column, and indcollation for each citext
      index column, as well.  Per report from Rudolf van der Leeden.
      9b97b7f8
    • Tom Lane's avatar
      Further code review for range types patch. · b985d487
      Tom Lane authored
      Fix some bugs in coercion logic and pg_dump; more comment cleanup;
      minor cosmetic improvements.
      b985d487
  6. 19 Nov, 2011 1 commit
    • Tom Lane's avatar
      Avoid floating-point underflow while tracking buffer allocation rate. · 40d35036
      Tom Lane authored
      When the system is idle for awhile after activity, the "smoothed_alloc"
      state variable in BgBufferSync converges slowly to zero.  With standard
      IEEE float arithmetic this results in several iterations with denormalized
      values, which causes kernel traps and annoying log messages on some
      poorly-designed platforms.  There's no real need to track such small values
      of smoothed_alloc, so we can prevent the kernel traps by forcing it to zero
      as soon as it's too small to be interesting for our purposes.  This issue
      is purely cosmetic, since the iterations don't happen fast enough for the
      kernel traps to pose any meaningful performance problem, but still it seems
      worth shutting up the log messages.
      
      The kernel log messages were previously reported by a number of people,
      but kudos to Greg Matthews for tracking down exactly where they were coming
      from.
      40d35036
  7. 18 Nov, 2011 5 commits
  8. 17 Nov, 2011 11 commits
  9. 16 Nov, 2011 2 commits
    • Tom Lane's avatar
      Code review for range-types catalog entries. · 4509033a
      Tom Lane authored
      Fix assorted infelicities, such as dependency on OIDs that aren't
      hardwired, as well as outright misdeclaration of daterange_canonical(),
      which resulted in crashes if you invoked it directly.  Add some more
      regression tests to try to catch similar mistakes in future.
      4509033a
    • Robert Haas's avatar
      Don't elide blank lines when accumulating psql command history. · ff4fd4bf
      Robert Haas authored
      This can change the meaning of queries, if the blank line happens to
      occur in the middle of a quoted literal, as per complaint from Tomas Vondra.
      
      Back-patch to all supported branches.
      ff4fd4bf
  10. 15 Nov, 2011 3 commits
    • Tom Lane's avatar
      Improve caching in range type I/O functions. · 04da3232
      Tom Lane authored
      Cache the the element type's I/O info across calls, not only the range
      type's info.  In passing, also clean up hash_range a bit more.
      04da3232
    • Tom Lane's avatar
      Restructure function-internal caching in the range type code. · 37ee4b75
      Tom Lane authored
      Move the responsibility for caching specialized information about range
      types into the type cache, so that the catalog lookups only have to occur
      once per session.  Rearrange APIs a bit so that fn_extra caching is
      actually effective in the GiST support code.  (Use of OidFunctionCallN is
      bad enough for performance in itself, but it also prevents the function
      from exploiting fn_extra caching.)
      
      The range I/O functions are still not very bright about caching repeated
      lookups, but that seems like material for a separate patch.
      
      Also, avoid unnecessary use of memcpy to fetch/store the range type OID and
      flags, and don't use the full range_deserialize machinery when all we need
      to see is the flags value.
      
      Also fix API error in range_gist_penalty --- it was failing to set *penalty
      for any case involving an empty range.
      37ee4b75
    • Tom Lane's avatar
      Fix alignment and toasting bugs in range types. · ad50934e
      Tom Lane authored
      A range type whose element type has 'd' alignment must have 'd' alignment
      itself, else there is no guarantee that the element value can be used
      in-place.  (Because range_deserialize uses att_align_pointer which forcibly
      aligns the given pointer, violations of this rule did not lead to SIGBUS
      but rather to garbage data being extracted, as in one of the added
      regression test cases.)
      
      Also, you can't put a toast pointer inside a range datum, since the
      referenced value could disappear with the range datum still present.
      For consistency with the handling of arrays and records, I also forced
      decompression of in-line-compressed bound values.  It would work to store
      them as-is, but our policy is to avoid situations that might result in
      double compression.
      
      Add assorted regression tests for this, and bump catversion because of
      fixes to built-in pg_type entries.
      
      Also some marginal cleanup of inconsistent/unnecessary error checks.
      ad50934e