1. 09 Nov, 2007 10 commits
  2. 08 Nov, 2007 16 commits
  3. 07 Nov, 2007 8 commits
  4. 06 Nov, 2007 2 commits
    • Michael Meskes's avatar
      Fixed two parser bugs. · e9d7bd26
      Michael Meskes authored
      e9d7bd26
    • Tom Lane's avatar
      Some code review for xml.c: · 5e512971
      Tom Lane authored
      Add some more xml_init() calls that might not be necessary, but seem like a
      good idea to avoid possible problems like we saw in xmlelement().
      Fix unsafe assumption that you can keep using the tupledesc of a relcache
      entry you don't have open.
      Add missing error checks for SearchSysCache failure.
      Get rid of handwritten array traversal in xpath() and O(N^2), broken-for-nulls
      array access code in map_sql_value_to_xml_value(), in favor of using
      deconstruct_array.
      Manually adjust a lot of line breaks in places where the code is otherwise
      gonna look pretty awful after pg_indent hacks it up (original author seems to
      have liked to lay out code for a 200-column window).
      5e512971
  5. 05 Nov, 2007 4 commits
    • Tom Lane's avatar
      Fix xmlelement() to initialize libxml correctly before using it, and to avoid · 85f807d7
      Tom Lane authored
      assuming that evaluation of its input expressions won't change the state of
      libxml.  This requires refactoring xml_init() to not call xmlInitParser(),
      since now not all of its callers want that.  I also tweaked things to avoid
      repeated execution of one-time-only tests inside xml_init(), though this is
      mostly for clarity rather than in hopes of saving any noticeable amount of
      runtime.  Per report from Sheikh Amjad and subsequent discussion.
      In passing, fix a couple of inadequately schema-qualified queries.
      85f807d7
    • Tom Lane's avatar
      Fix deprecated-by-C-spec usage: storage class should come before const · bcb3852c
      Tom Lane authored
      decoration.  Zdenek Kotala
      bcb3852c
    • Tom Lane's avatar
      Improve conversion of legacy CREATE CONSTRAINT TRIGGER representation of · df870740
      Tom Lane authored
      foreign keys, one more time.  Insist on matching up all three triggers before
      we create a constraint; this will avoid creation of duplicate constraints
      in scenarios where a broken FK constraint was repaired by re-adding the
      constraint without removing the old partial trigger set.  Basically, this will
      work nicely in all cases where the FK was actually functioning correctly in
      the database that was dumped.  It will fail to restore an FK in just one case
      where we theoretically could restore it: where we find the referenced table's
      triggers and not the referencing table's trigger.  However, in such a scenario
      it's likely that the user doesn't even realize he still has an FK at all
      (since the more-likely-to-fail cases aren't enforced), and we'd probably not
      accomplish much except to cause the reload to fail because the data doesn't
      meet the FK constraint.  Also make the NOTICE logging still more verbose, by
      adding detail about which of the triggers were found.  This seems about all
      we can do without solving the problem of getting the user's attention at
      session end.
      df870740
    • Bruce Momjian's avatar
      Document that configure option only affects contrib: · c1a03bee
      Bruce Momjian authored
       --with-ossp-uuid        use OSSP UUID library when building /contrib/uuid-ossp
      c1a03bee