- 19 Nov, 2006 1 commit
-
-
Tom Lane authored
preference for filling pages out-of-order tends to confuse the sanity checks in md.c, as per report from Balazs Nagy in bug #2737. The fix is to ensure that the smgr-level code always has the same idea of the logical EOF as the hash index code does, by using ReadBuffer(P_NEW) where we are adding a single page to the end of the index, and using smgrextend() to reserve a large batch of pages when creating a new splitpoint. The patch is a bit ugly because it avoids making any changes in md.c, which seems the most prudent approach for a backpatchable beta-period fix. After 8.3 development opens, I'll take a look at a cleaner but more invasive patch, in particular getting rid of the now unnecessary hack to allow reading beyond EOF in mdread(). Backpatch as far as 7.4. The bug likely exists in 7.3 as well, but because of the magnitude of the 7.3-to-7.4 changes in hash, the later-version patch doesn't even begin to apply. Given the other known bugs in the 7.3-era hash code, it does not seem worth trying to develop a separate patch for 7.3.
-
- 17 Nov, 2006 9 commits
-
-
Tom Lane authored
people from trying notations like '10.6/16', which is accepted but does not mean what you probably think. Per example from Paul Forgey.
-
Tom Lane authored
cases where we already hold the desired lock "indirectly", either via membership in a MultiXact or because the lock was originally taken by a different subtransaction of the current transaction. These cases must be accounted for to avoid needless deadlocks and/or inappropriate replacement of an exclusive lock with a shared lock. Per report from Clarence Gardner and subsequent investigation.
-
Peter Eisentraut authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Neil Conway authored
-
Michael Meskes authored
-
Neil Conway authored
that discusses CVS. Remove the recommendation to use cvs 1.10. Remove discussion of alleged CVSup binaries on postgresql.org, because they have not existed for several years. Remove discussion of how to build cvsup from source because the existing text is outdated, and more accurate information is available from the CVSup homepage.
-
Bruce Momjian authored
-
- 16 Nov, 2006 5 commits
-
-
Bruce Momjian authored
-
Bruce Momjian authored
than new sections, so they appear all on the same web page.
-
Bruce Momjian authored
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
- 15 Nov, 2006 1 commit
-
-
Bruce Momjian authored
-
- 14 Nov, 2006 4 commits
-
-
-
Bruce Momjian authored
-
Bruce Momjian authored
-
Bruce Momjian authored
-
- 13 Nov, 2006 1 commit
-
-
Andrew Dunstan authored
on an attempt to create the second interpreter if this is not supported by the perl installation. Per recent -hackers discussion.
-
- 12 Nov, 2006 3 commits
-
-
Neil Conway authored
-
Neil Conway authored
consistently capitalize the content of the "Description" column but do not include a terminating period, as is the convention elsewhere in the docs. Also, remove the "References" column from catalog that do not have any referencing columns, for the sake of brevity. Make various other SGML and grammar fixes.
-
Neil Conway authored
-
- 11 Nov, 2006 1 commit
-
-
Tom Lane authored
-O3 or higher (presumably because it inlines more things). Per gripe from Mark Mielke.
-
- 10 Nov, 2006 7 commits
-
-
Tom Lane authored
of an index on a serial column, rather than the name of the associated sequence. Fallout from recent changes in dependency setup for serials. Per bug #2732 from Basil Evseenko.
-
Tom Lane authored
-
Tom Lane authored
Theo Kramer.
-
Tom Lane authored
the database. xfunc.sgml was already pretty definite on the point, but it doesn't hurt to make it clear here too.
-
Tom Lane authored
added to information_schema (per a SQL2003 addition). The original coding failed if a referenced column participated in more than one pg_constraint entry. Also, it did not work if an FK relied directly on a unique index without any constraint syntactic sugar --- this case is outside the SQL spec, but PG has always supported it, so it's reasonable for our information_schema to handle it too. Per bug#2750 from Stephen Haberman. Although this patch changes the initial catalog contents, I didn't force initdb. Any beta3 testers who need the fix can install it via CREATE OR REPLACE VIEW, so forcing them to initdb seems an unnecessary imposition.
-
Neil Conway authored
for NULL-ness of function arguments is wasted code.
-
Tom Lane authored
accurately: we have to distinguish the effects of the join's own ON clauses from the effects of pushed-down clauses. Failing to do so was a quick hack long ago, but it's time to be smarter. Per example from Thomas H.
-
- 08 Nov, 2006 8 commits
-
-
Tom Lane authored
30 seconds instead of retrying forever. Also modify xlog.c so that if it fails to rename an old xlog segment up to a future slot, it will unlink the segment instead. Per discussion of bug #2712, in which it became apparent that Windows can handle unlinking a file that's being held open, but not renaming it.
-
Tom Lane authored
The former coding relied on the actual allocated size of the last block, which made it behave strangely if the first allocation in a context was larger than ALLOC_CHUNK_LIMIT: subsequent allocations would be referenced to that and not to the intended series of block sizes. Noted while studying a memory wastage gripe from Tatsuo.
-
Tom Lane authored
more space is needed, instead of incrementing by a fixed amount; the old method wastes lots of space and time when the ultimate size is large. Per gripe from Tatsuo.
-
Tom Lane authored
text_to_array(): they all had O(N^2) behavior on long input strings in multibyte encodings, because of repeated rescanning of the input text to identify substrings whose positions/lengths were computed in characters instead of bytes. Fix by tracking the current source position as a char pointer as well as a character-count. Also avoid some unnecessary palloc operations. text_to_array() also leaked memory intracall due to failure to pfree temporary strings. Per gripe from Tatsuo Ishii.
-
Neil Conway authored
-
Teodor Sigaev authored
-
Michael Meskes authored
-
Neil Conway authored
a connectivity error occurred while executing one of the queries for "\d <table>". Not serious, but still worth fixing. Patch from Brendan Jurd.
-