- 27 Oct, 2008 6 commits
-
-
Tom Lane authored
recursion when we are unable to convert a localized error message to the client's encoding. We've been over this ground before, but as reported by Ibrar Ahmed, it still didn't work in the case of conversion failures for the conversion-failure message itself :-(. Fix by installing a "circuit breaker" that disables attempts to localize this message once we get into recursion trouble. Patch all supported branches, because it is in fact broken in all of them; though I had to add some missing translations to the older branches in order to expose the failure in the particular test case I was using.
-
Magnus Hagander authored
after each other (since we already add a newline on each, this makes them multiline). Previously a new error would just overwrite the old one, so for example any error caused when trying to connect with SSL enabled would be overwritten by the error message form the non-SSL connection when using sslmode=prefer.
-
Peter Eisentraut authored
-
Magnus Hagander authored
libpq events code. Hiroshi Saito
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
- 26 Oct, 2008 1 commit
-
-
Tom Lane authored
treat Var and non-Var IN-list items differently. Only non-Var items are candidates to go into an ANY(ARRAY) construct --- we put all Vars as separate OR conditions on the grounds that that leaves more scope for optimization. Per suggestion from Robert Haas.
-
- 25 Oct, 2008 2 commits
-
-
Tom Lane authored
only the outer side can be pushed down rather than having to be evaluated at the join.
-
Tom Lane authored
into an OR of equality comparisons, rather than x = ANY(ARRAY[...]), when there are Vars in the right-hand side. This avoids a performance regression compared to pre-8.2 releases, in cases where the OR form can be optimized into scans of multiple indexes. Limit the possible downside by preferring this form only when the list isn't very long (I set the cutoff at 32 elements, which is a bit arbitrary but in the right ballpark). Per discussion with Jim Nasby. In passing, also make it try the OR form if it cannot select a common type for the array elements; we've seen a complaint or two about how the OR form worked for such cases and ARRAY doesn't.
-
- 24 Oct, 2008 5 commits
-
-
Tom Lane authored
recent proposal. In typical cases, we now need 12 bytes per insert or delete event and 16 bytes per update event; previously we needed 40 bytes per event on 32-bit hardware and 80 bytes per event on 64-bit hardware. Even in the worst case usage pattern with a large number of distinct triggers being fired in one query, usage is at most 32 bytes per event. It seems to be a bit faster than the old code as well, due to reduction of palloc overhead. This commit doesn't address the TODO item of allowing the event list to spill to disk; rather it's trying to stave off the need for that. However, it probably makes that task a bit easier by reducing the data structure's dependency on pointers. It would now be practical to dump an event list to disk by "chunks" instead of individual events.
-
Magnus Hagander authored
-
Magnus Hagander authored
end-user documentation that lives in the actual documentation.
-
Magnus Hagander authored
to the old set of SSL patches. Hasn't been updated since, and we keep the TODOs in the "real" TODO list, really...
-
Magnus Hagander authored
of copy/paste:d emails. Much of the contents had already been migrated into the main documentation, some was out of date and some just plain wrong. Keep the "protocol-flowchart" which can still be useful.
-
- 23 Oct, 2008 7 commits
-
-
Magnus Hagander authored
-
Tom Lane authored
in their targetlists had better reset ps_TupFromTlist during ReScan calls. There's no need to back-patch here since nodeAgg and nodeGroup didn't even pretend to support SRFs in prior releases.
-
Tom Lane authored
used long ago, but in the current code the ecxt_outertuple field of ExprContext is doing all the work. Spotted by Ran Tang.
-
Magnus Hagander authored
* make LDAP use this instead of the hacky previous method to specify the DN to bind as * make all auth options behave the same when they are not compiled into the server * rename "ident maps" to "user name maps", and support them for all auth methods that provide an external username This makes a backwards incompatible change in the format of pg_hba.conf for the ident, PAM and LDAP authentication methods.
-
Peter Eisentraut authored
(INCLUDING/EXCLUDING DEFAULTS)
-
Peter Eisentraut authored
-
Tom Lane authored
inputs is unique or nearly so), make eqjoinsel() clamp the ndistinct estimates to be not more than the estimated number of rows coming from the input relations. This allows the estimate to change in response to the selectivity of restriction conditions on the inputs. This is a pretty narrow patch and maybe we should be more aggressive about similarly clamping ndistinct in other cases; but I'm worried about double-counting the effects of the restriction conditions. However, it seems to help for the case exhibited by Grzegorz Jaskiewicz (antijoin against a small subset of a relation), so let's try this for awhile.
-
- 22 Oct, 2008 3 commits
-
-
Tom Lane authored
until vars are distributed to rels during query_planner() startup. We don't really need it before that, and not building it early has some advantages. First, we don't need to put it through the various preprocessing steps, which saves some cycles and eliminates the need for a number of routines to support PlaceHolderInfo nodes at all. Second, this means one less unused plan for any sub-SELECT appearing in a placeholder's expression, since we don't build placeholder_list until after sublink expansion is complete.
-
Teodor Sigaev authored
correctly set. As result, killtuple() marks as dead wrong tuple on page. Bug was introduced by me while fixing possible duplicates during GiST index scan.
-
Peter Eisentraut authored
OFFSET num {ROW|ROWS} FETCH {FIRST|NEXT} [num] {ROW|ROWS} ONLY
-
- 21 Oct, 2008 4 commits
-
-
Tom Lane authored
that represent some expression that we desire to compute below the top level of the plan, and then let that value "bubble up" as though it were a plain Var (ie, a column value). The immediate application is to allow sub-selects to be flattened even when they are below an outer join and have non-nullable output expressions. Formerly we couldn't flatten because such an expression wouldn't properly go to NULL when evaluated above the outer join. Now, we wrap it in a PlaceHolderVar and arrange for the actual evaluation to occur below the outer join. When the resulting Var bubbles up through the join, it will be set to NULL if necessary, yielding the correct results. This fixes a planner limitation that's existed since 7.1. In future we might want to use this mechanism to re-introduce some form of Hellerstein's "expensive functions" optimization, ie place the evaluation of an expensive function at the most suitable point in the plan tree.
-
Peter Eisentraut authored
-
Peter Eisentraut authored
error messages where the type existence is established.
-
Peter Eisentraut authored
alongside our traditional syntax.
-
- 20 Oct, 2008 10 commits
-
-
Alvaro Herrera authored
knowledge of page layout. Stolen from Jonah Harris' CRC patch
-
Alvaro Herrera authored
Zdenek Kotala.
-
Alvaro Herrera authored
This patch eliminates the marking of subtransactions as SUBCOMMITTED in pg_clog during their commit; instead they remain in-progress until main transaction commit. At main transaction commit, the commit protocol is atomic-by-page instead of one transaction at a time. To avoid a race condition with some subtransactions appearing committed before others in the case where they span more than one pg_clog page, we conserve the logic that marks them subcommitted before marking the parent committed. Simon Riggs with minor help from me
-
Peter Eisentraut authored
-
Peter Eisentraut authored
dropped or it was a mistake.
-
Peter Eisentraut authored
-
Teodor Sigaev authored
Per Tom's comment. Also revome useless GISTScanOpaque->flags field.
-
Peter Eisentraut authored
supported, to the extent that LOBs, arrays, and multisets are supported.
-
Peter Eisentraut authored
-
- 18 Oct, 2008 2 commits
-
-
Peter Eisentraut authored
-
Tom Lane authored
-