- 24 Aug, 2009 4 commits
-
-
Tom Lane authored
#include the version of history.h that is in the same directory as the readline.h we are using. This avoids problems in some scenarios where both readline and editline are installed. Report and patch by Zdenek Kotala.
-
Alvaro Herrera authored
Per Grzegorz Jaskiewicz report from LLVM static checker
-
Tom Lane authored
renders useless one of the few test methodologies we have for WAL replay, which is to intentionally crash the system just after completing the regression tests and see if it recovers to the expected database state. The reason is that DROP TABLESPACE forces a checkpoint, so there's essentially no WAL available for replay after the tests complete.
-
Tom Lane authored
"all tuples visible" flag in heap page headers. The flag update *must* be applied before calling XLogInsert, but heap_update and the tuple moving routines in VACUUM FULL were ignoring this rule. A crash and replay could therefore leave the flag incorrectly set, causing rows to appear visible in seqscans when they should not be. This might explain recent reports of data corruption from Jeff Ross and others. In passing, do a bit of editorialization on comments in visibilitymap.c.
-
- 23 Aug, 2009 2 commits
-
-
Tom Lane authored
or previously truncated in the current (sub)transaction. This is safe since if the (sub)transaction later rolls back, we'd just discard the rel's current physical file anyway. This avoids unreasonable growth in the number of transient files when a relation is repeatedly truncated. Per a performance gripe a couple weeks ago from Todd Cook.
-
Tom Lane authored
values before they get passed to the index access method. This avoids repeated detoastings that will otherwise ensue as the comparison value is examined by various index support functions. We have seen a couple of reports of cases where repeated detoastings result in an order-of-magnitude slowdown, so it seems worth adding a bit of extra logic to prevent this. I had previously proposed trying to avoid duplicate detoastings in general, but this fix takes care of what seems the most important case in practice with very little effort or risk. Back-patch to 8.4 so that the PostGIS folk won't have to wait a year to have this fix in a production release. (The issue exists further back, of course, but the code's diverged enough to make backpatching further a higher-risk action. Also it appears that the possible gains may be limited in prior releases because of different handling of lossy operators.)
-
- 22 Aug, 2009 1 commit
-
-
Tom Lane authored
-
- 20 Aug, 2009 1 commit
-
-
Bruce Momjian authored
-
- 19 Aug, 2009 3 commits
-
-
Tom Lane authored
Peter did that without fixing this ...
-
Peter Eisentraut authored
per Pavel Stehule
-
Peter Eisentraut authored
-
- 18 Aug, 2009 10 commits
-
-
Tom Lane authored
about it doesn't simplify the grammar at all, and it does invite confusion among those who only read the SELECT syntax summary and not the full details. Per gripe from Jaime Casanova.
-
Andrew Dunstan authored
Pick up REGRESS_OPTS from contrib makefiles. Along the way, fix ordering of makefile tests to mimic gmake.
-
Tom Lane authored
and integer datetimes are in use. Per bug report from Hubert Depesz Lubaczewski. Alex Hunsaker
-
Peter Eisentraut authored
-
Tom Lane authored
This is to help make it more obvious what the problem is, if the encoding isn't what the test expects.
-
Tom Lane authored
-
Tom Lane authored
indigestion about this module.
-
Tom Lane authored
-
Teodor Sigaev authored
-
Teodor Sigaev authored
to CREATE DATABASE command in pg_regress to allow correct checking of locale-sensitive contrib modules.
-
- 17 Aug, 2009 3 commits
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
cheats a bit, but it avoids unsatisfied dependencies in distribution tarballs. (found by make distcheck)
-
Tom Lane authored
physical conversion when there are dropped columns in the same places in the input and output tupdescs. This avoids possible performance loss from the recent patch to improve dropped-column handling, in some cases where the old code would have worked.
-
- 16 Aug, 2009 2 commits
-
-
Tom Lane authored
This was changed in 8.2 but the documentation was not corrected. Per gripe from Sam Mason.
-
Tom Lane authored
truncate_identifier won't do anything if the passed-in strlen is already less than NAMEDATALEN, which it always would be given the strlcpy usage. This has been broken since the arrays-of-composite-types code went in. Arguably truncate_identifier is suffering from excessive optimization and should always process the string, but for the moment I'll take the more localized patch. Per bug #4987.
-
- 15 Aug, 2009 3 commits
-
-
Tom Lane authored
This test is clearly not being used anymore, since it's been broken for long periods of time without anyone noticing. Per discussion, it's not worth keeping in our source tree.
-
Tom Lane authored
to be shipped. Also, allow 'make clean' to remove intermediate working files.
-
Peter Eisentraut authored
Berkus.
-
- 14 Aug, 2009 7 commits
-
-
Peter Eisentraut authored
-
Alvaro Herrera authored
-
Tom Lane authored
for standalone backends. Although we probably ought to just remove this long-obsolete test case from our code, it seems worthwhile to document the issue and fix in CVS first. Jeff Janes
-
Teodor Sigaev authored
-
Peter Eisentraut authored
Add some checks on various data types are converted into and out of Python. This is extracted from Caleb Welton's patch for improved bytea support, but much expanded.
-
Michael Meskes authored
Böszörményi Zoltán <zb@cybertec.at>.
-
Peter Eisentraut authored
When examining what Python type to convert a PostgreSQL type to on input, look at the base type of the input type, otherwise all domains end up defaulting to string.
-
- 13 Aug, 2009 4 commits
-
-
Peter Eisentraut authored
-
Peter Eisentraut authored
-
Tom Lane authored
since we're evidently not testing that at all right now :-(
-
Tom Lane authored
I mistakenly removed it last month, thinking it was no longer needed --- but it is still needed for dealing with joininfo lists. Fortunately this bit of brain fade hadn't made it into any released versions yet.
-