1. 21 Nov, 2009 2 commits
    • Peter Eisentraut's avatar
      Ignore UTF-8-encoded Unicode byte-order mark at the beginning of a file if · 93d3bac5
      Peter Eisentraut authored
      the client encoding is UTF-8.
      
      a limited version of a patch proposed by Itagaki Takahiro
      93d3bac5
    • Tom Lane's avatar
      Refactor ecpg grammar so that it uses the core grammar's unreserved_keyword · e6c63bf6
      Tom Lane authored
      list, minus a few specific words that have to be treated specially.  This
      replaces a hard-wired list of keywords that would have needed manual
      maintenance, and was not getting it.  The 8.4 coding was already missing
      these words, causing ecpg to incorrectly treat them as reserved words:
      CALLED, CATALOG, DEFINER, ENUM, FOLLOWING, INVOKER, OPTIONS, PARTITION,
      PRECEDING, RANGE, SECURITY, SERVER, UNBOUNDED, WRAPPER.  In HEAD we were
      additionally missing COMMENTS, FUNCTIONS, SEQUENCES, TABLES.
      Per gripe from Bosco Rama.
      e6c63bf6
  2. 20 Nov, 2009 1 commit
    • Tom Lane's avatar
      Add a WHEN clause to CREATE TRIGGER, allowing a boolean expression to be · 7fc0f062
      Tom Lane authored
      checked to determine whether the trigger should be fired.
      
      For BEFORE triggers this is mostly a matter of spec compliance; but for AFTER
      triggers it can provide a noticeable performance improvement, since queuing of
      a deferred trigger event and re-fetching of the row(s) at end of statement can
      be short-circuited if the trigger does not need to be fired.
      
      Takahiro Itagaki, reviewed by KaiGai Kohei.
      7fc0f062
  3. 19 Nov, 2009 2 commits
    • Peter Eisentraut's avatar
      Typo: dump -> restore · 201a45c4
      Peter Eisentraut authored
      fixed in 8.4 and 8.5
      
      Author: Guillaume Lelarge <guillaume@lelarge.info>
      201a45c4
    • Tom Lane's avatar
      Fix memory leak in syslogger: logfile_rotate() would leak a copy of the · b1d55dca
      Tom Lane authored
      output filename if CSV logging was enabled and only one of the two possible
      output files got rotated during a particular call (which would, in fact,
      typically be the case during a size-based rotation).  This would amount to
      about MAXPGPATH (1KB) per rotation, and it's been there since the CSV
      code was put in, so it's surprising that nobody noticed it before.
      Per bug #5196 from Thomas Poindessous.
      b1d55dca
  4. 18 Nov, 2009 1 commit
  5. 16 Nov, 2009 2 commits
    • Tom Lane's avatar
      Provide a parenthesized-options syntax for VACUUM, analogous to that recently · 5e66a51c
      Tom Lane authored
      adopted for EXPLAIN.  This will allow additional options to be implemented
      in future without having to make them fully-reserved keywords.  The old syntax
      remains available for existing options, however.
      
      Itagaki Takahiro
      5e66a51c
    • Tom Lane's avatar
      While doing the final setrefs.c pass over a plan tree, try to match up · 49ed392c
      Tom Lane authored
      non-Var sort/group expressions using ressortgroupref labels instead of
      depending entirely on equal()-ity of the upper node's tlist expressions
      to the lower node's.  This avoids emitting the wrong outputs in cases
      where there are textually identical volatile sort/group expressions,
      as for example
      	select distinct random(),random() from generate_series(1,10);
      Per report from Andrew Gierth.
      
      Backpatch to 8.4.  Arguably this is wrong all the way back, but the only known
      case where there's an observable problem is when using hash aggregation to
      implement DISTINCT, which is new as of 8.4.  So for the moment I'll refrain
      from backpatching further.
      49ed392c
  6. 15 Nov, 2009 2 commits
  7. 14 Nov, 2009 2 commits
  8. 13 Nov, 2009 6 commits
  9. 12 Nov, 2009 5 commits
  10. 11 Nov, 2009 4 commits
  11. 10 Nov, 2009 7 commits
    • Tom Lane's avatar
      Do not build psql's flex module on its own, but instead include it in · 90bfe999
      Tom Lane authored
      mainloop.c.  This ensures that postgres_fe.h is read before including
      any system headers, which is necessary to avoid problems on some platforms
      where we make nondefault selections of feature macros for stdio.h or
      other headers.  We have had this policy for flex modules in the backend
      for many years, but for some reason it was not applied to psql.
      Per trouble report from Alexandra Roy and diagnosis by Albe Laurenz.
      90bfe999
    • Tom Lane's avatar
      Revert the temporary patch to work around Snow Leopard readdir() bug. · 21e3edd6
      Tom Lane authored
      Apple has fixed that bug in 10.6.2, and we should encourage users to
      update to that version rather than trusting this cosmetic patch.
      As was recently noted by Stephen Tyler, this patch was only masking
      the problem in the context of DROP TABLESPACE, but the failure could
      occur in other places such as pg_xlog cleanup.
      21e3edd6
    • Bruce Momjian's avatar
      interval_abs(): · 089f4b92
      Bruce Momjian authored
      Add C comment about why there is no interval_abs():  it is unclear what
      value to return:
      
          http://archives.postgresql.org/pgsql-general/2009-10/msg01031.php
          http://archives.postgresql.org/pgsql-general/2009-11/msg00041.php
      089f4b92
    • Alvaro Herrera's avatar
      Fix longstanding problems in VACUUM caused by untimely interruptions · e7ec0222
      Alvaro Herrera authored
      In VACUUM FULL, an interrupt after the initial transaction has been recorded
      as committed can cause postmaster to restart with the following error message:
      PANIC: cannot abort transaction NNNN, it was already committed
      This problem has been reported many times.
      
      In lazy VACUUM, an interrupt after the table has been truncated by
      lazy_truncate_heap causes other backends' relcache to still point to the
      removed pages; this can cause future INSERT and UPDATE queries to error out
      with the following error message:
      could not read block XX of relation 1663/NNN/MMMM: read only 0 of 8192 bytes
      The window to this race condition is extremely narrow, but it has been seen in
      the wild involving a cancelled autovacuum process.
      
      The solution for both problems is to inhibit interrupts in both operations
      until after the respective transactions have been committed.  It's not a
      complete solution, because the transaction could theoretically be aborted by
      some other error, but at least fixes the most common causes of both problems.
      e7ec0222
    • Bruce Momjian's avatar
      DIAGNOSTICS/FOUND wording · b538b72e
      Bruce Momjian authored
      Update wording of GET DIAGNOSTICS/FOUND, per David Fetter.
      b538b72e
    • Tom Lane's avatar
      More incremental refactoring in plpgsql: get rid of gram.y dependencies on · 73a2f6c6
      Tom Lane authored
      yytext.  This is a necessary change if we're going to have a lexer interface
      layer that does lookahead, since yytext won't necessarily be in step with
      what the grammar thinks is the current token.  yylval and yylloc should
      be the only side-variables that we need to manage when doing lookahead.
      73a2f6c6
    • Bruce Momjian's avatar
      PL/pgSQL FOUND · 6ac697f1
      Bruce Momjian authored
      Document that GET DIAGNOSTICS is affected by EXECUTE, while FOUND is
      not.
      6ac697f1
  12. 09 Nov, 2009 3 commits
    • Tom Lane's avatar
      Re-refactor the core scanner's API, in order to get out from under the problem · 10bcfa18
      Tom Lane authored
      of different parsers having different YYSTYPE unions that they want to use
      with it.  I defined a new union core_YYSTYPE that is just the (very short)
      list of semantic values returned by the core scanner.  I had originally
      worried that this would require an extra interface layer, but actually we can
      have parser.c's base_yylex (formerly filtered_base_yylex) take care of that at
      no extra cost.  Names associated with the core scanner are now "core_yy_foo",
      with "base_yy_foo" being used in the core Bison parser and the parser.c
      interface layer.
      
      This solves the last serious stumbling block to eliminating plpgsql's separate
      lexer.  One restriction that will still be present is that plpgsql and the
      core will have to agree on the token numbers assigned to tokens that can be
      returned by the core lexer.  Since Bison doesn't seem willing to accept
      external assignments of those numbers, we'll have to live with decreeing that
      core and plpgsql grammars declare these tokens first and in the same order.
      10bcfa18
    • Tom Lane's avatar
      Fix WHERE CURRENT OF to work as designed within plpgsql. The argument · 2ace38d2
      Tom Lane authored
      can be the name of a plpgsql cursor variable, which formerly was converted
      to $N before the core parser saw it, but that's no longer the case.
      Deal with plain name references to plpgsql variables, and add a regression
      test case that exposes the failure.
      2ace38d2
    • Tom Lane's avatar
      Modernize plpgsql's handling of parse locations, making it look a lot more · 39bd3fd1
      Tom Lane authored
      like the core parser's code.  In particular, track locations at the character
      rather than line level during parsing, allowing many more parse-time error
      conditions to be reported with precise error pointers rather than just
      "near line N".
      
      Also, exploit the fact that we no longer need to substitute $N for variable
      references by making extracted SQL queries and expressions be exact copies
      of subranges of the function text, rather than having random whitespace
      changes within them.  This makes it possible to directly map parse error
      positions from the core parser onto positions in the function text, which
      lets us report them without the previous kluge of showing the intermediate
      internal-query form.  (Later it might be good to do that for core
      parse-analysis errors too, but this patch is just touching plpgsql's
      lexer/parser, not what happens at runtime.)
      
      In passing, make plpgsql's lexer use palloc not malloc.
      
      These changes make plpgsql's parse-time error reports noticeably nicer
      (as illustrated by the regression test changes), and will also simplify
      the planned removal of plpgsql's separate lexer by reducing the impedance
      mismatch between what it does and what the core lexer does.
      39bd3fd1
  13. 07 Nov, 2009 2 commits
    • Tom Lane's avatar
      Remove ancient text file containing plpgsql installation instructions. · fb60af41
      Tom Lane authored
      This was long ago superseded by the standard build process and main
      SGML documentation.
      fb60af41
    • Tom Lane's avatar
      Rearrange plpgsql parsing to simplify and speed it up a bit. · f2b7692e
      Tom Lane authored
      * Pull the responsibility for %TYPE and %ROWTYPE out of the scanner,
      letting read_datatype manage it instead.
      
      * Avoid unnecessary scanner-driven lookups of plpgsql variables in
      places where it's not needed, which is actually most of the time;
      we do not need it in DECLARE sections nor in text that is a SQL
      query or expression.
      
      * Rationalize the set of token types returned by the scanner:
      distinguishing T_SCALAR, T_RECORD, T_ROW seems to complicate the grammar
      in more places than it simplifies it, so merge these into one
      token type T_DATUM; but split T_ERROR into T_DBLWORD and T_TRIPWORD
      for clarity and simplicity of later processing.
      
      Some of this will need to be revisited again when we try to make
      plpgsql use the core scanner, but this patch gets some of the bigger
      stumbling blocks out of the way.
      f2b7692e
  14. 06 Nov, 2009 1 commit