1. 26 Aug, 2004 8 commits
  2. 25 Aug, 2004 2 commits
    • Tom Lane's avatar
      Fix typo in comment, per Andrew Dunstan. · 7584194c
      Tom Lane authored
      7584194c
    • Tom Lane's avatar
      Revise ResourceOwner code to avoid accumulating ResourceOwner objects · fe455ee1
      Tom Lane authored
      for every command executed within a transaction.  For long transactions
      this was a significant memory leak.  Instead, we can delete a portal's
      or subtransaction's ResourceOwner immediately, if we physically transfer
      the information about its locks up to the parent owner.  This does not
      fully solve the leak problem; we need to do something about counting
      multiple acquisitions of the same lock in order to fix it.  But it's a
      necessary step along the way.
      fe455ee1
  3. 24 Aug, 2004 5 commits
    • Peter Eisentraut's avatar
      Translation update · b662311d
      Peter Eisentraut authored
      b662311d
    • Peter Eisentraut's avatar
      Translation update · a56cebb1
      Peter Eisentraut authored
      a56cebb1
    • Tom Lane's avatar
      Allow second and subsequent names in a qualified (dotted) name to be · 3cb1ffa6
      Tom Lane authored
      ColLabel instead of just ColId --- that is, any keyword can appear after
      a dot and it will be taken as an identifier.  Fixes problems with names
      that are okay as standalone function names but fail when qualified.
      3cb1ffa6
    • Bruce Momjian's avatar
      Update item: · 4359ebed
      Bruce Momjian authored
      < * Implement dirty reads or shared row locks and use them in RI triggers (?)
      > * Implement dirty reads or shared row locks and use them in RI triggers
      >
      >   Adding shared locks requires recording the table/rows numbers in a
      >   shared area, and this could potentially be a large amount of data.
      >   One idea is to store the table/row numbers in a separate table and set
      >   a bit on the row indicating looking in this new table is required to
      >   find any shared row locks.
      >
      4359ebed
    • Neil Conway's avatar
      Various minor improvements to the SGML documentation: fix some incorrect · cda1bd6c
      Neil Conway authored
      SGML markup, add a "deprecated features" section to the 8.0 release
      notes, untabify release.sgml and runtime.sgml, and make some other
      minor improvements.
      cda1bd6c
  4. 23 Aug, 2004 4 commits
  5. 22 Aug, 2004 2 commits
    • Tom Lane's avatar
      Tweak code so that pg_subtrans is never consulted for XIDs older than · f009c316
      Tom Lane authored
      RecentXmin (== MyProc->xmin).  This ensures that it will be safe to
      truncate pg_subtrans at RecentGlobalXmin, which should largely eliminate
      any fear of bloat.  Along the way, eliminate SubTransXidsHaveCommonAncestor,
      which isn't really needed and could not give a trustworthy result anyway
      under the lookback restriction.
      In an unrelated but nearby change, #ifdef out GetUndoRecPtr, which has
      been dead code since 2001 and seems unlikely to ever be resurrected.
      f009c316
    • Tom Lane's avatar
      Code review for ALTER INDEX patch. · 37d937ea
      Tom Lane authored
      37d937ea
  6. 21 Aug, 2004 8 commits
  7. 20 Aug, 2004 11 commits
    • Tom Lane's avatar
      Recognize plpgsql EXCEPTION condition names at function compile time · bf9d9bd2
      Tom Lane authored
      instead of runtime, for better detection of invalid condition names
      (and maybe a little more speed, too).
      bf9d9bd2
    • Bruce Momjian's avatar
      >>At this stage of the game I would just change pg_hba.conf.sample to use · 009b0d1a
      Bruce Momjian authored
      >>'127.0.0.1/32' instead of '127.0.0.1 255.255.255.255'.
      >>
      >>
      >
      >Yeah, that's probably the path of least resistance.  Note that the
      >comments and possibly the SGML docs need to be adjusted to match,
      >however, so it's not quite a one-liner.
      
      Andrew Dunstan
      009b0d1a
    • Bruce Momjian's avatar
      Allow psql to use 7.4.X database by not referencing tablespaces. · 3ca998b9
      Bruce Momjian authored
      Greg Sabino Mullan
      3ca998b9
    • Bruce Momjian's avatar
      > Please find enclose a submission to fix these problems. · ee85595d
      Bruce Momjian authored
      >
      > The patch adds missing the "libpgport.a" file to the installation under
      > "install-all-headers". It is needed by some contribs. I install the
      > library in "pkglibdir", but I was wondering whether it should be "libdir"?
      > I was wondering also whether it would make sense to have a "libpgport.so"?
      >
      > It fixes various macros which are used by contrib makefiles, especially
      > libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are
      > needed to
      >
      > It adds the ability to test and use PGXS with contribs, with "make
      > USE_PGXS=1". Without the macro, this is exactly as before, there should be
      > no difference, esp. wrt the vpath feature that seemed broken by previous
      > submission. So it should not harm anybody, and it is useful at least to me.
      >
      > It fixes some inconsistencies in various contrib makefiles
      > (useless override, ":=" instead of "=").
      
      Fabien COELHO
      ee85595d
    • Bruce Momjian's avatar
      Add ALTER SCHEMA item detail: · ff8e5526
      Bruce Momjian authored
      < 	o Allow databases, schemas, and indexes to be moved to different
      < 	  tablespaces
      > 	o Allow databases and schemas to be moved to different tablespaces
      >
      > 	One complexity is whether moving a schema should move all existing
      > 	schema objects or just define the location for future object creation.
      >
      382c385
      < 	o Add ALTER INDEX that works just like ALTER TABLE already does
      > 	o -Add ALTER INDEX that works just like ALTER TABLE already does
      384d386
      < 	o Add ALTER INDEX syntax to work like ALTER TABLE indexname
      ff8e5526
    • Bruce Momjian's avatar
      They are two different problems; the TOC entry is important for any · f7168bd4
      Bruce Momjian authored
      multiline command  or to rerun the command easily later.
      
      Whereas displaying the failed SQL command is a matter of fixing the
      error
      messages.
      
      The latter is complicated by failed COPY commands which, with
      die-on-errors
      off, results in the data being processed as a command, so dumping the
      command will dump all of the data.
      
      In the case of long commands, should the whole command be dumped? eg.
      (eg.
      several pages of function definition).
      
      In the case of the COPY command, I'm not sure what to do. Obviously, it
      would be best to avoid sending the data, but the data and command are
      combined (from memory). Also, the 'data' may be in the form of INSERT
      statements.
      
      Attached patch produces the first 125 chars of the command:
      
      pg_restore: [archiver (db)] Error while PROCESSING TOC:
      pg_restore: [archiver (db)] Error from TOC Entry 26; 1255 16449270
      FUNCTION
      plpgsql_call_handler() pjw
      pg_restore: [archiver (db)] could not execute query: ERROR:  function
      "plpgsql_call_handler" already exists with same argument types
           Command was: CREATE FUNCTION plpgsql_call_handler() RETURNS
      language_handler
           AS '/var/lib/pgsql-8.0b1/lib/plpgsql', 'plpgsql_call_han...
      pg_restore: [archiver (db)] Error from TOC Entry 27; 1255 16449271
      FUNCTION
      plpgsql_validator(oid) pjw
      pg_restore: [archiver (db)] could not execute query: ERROR:  function
      "plpgsql_validator" already exists with same argument types
           Command was: CREATE FUNCTION plpgsql_validator(oid) RETURNS void
           AS '/var/lib/pgsql-8.0b1/lib/plpgsql', 'plpgsql_validator'
           LANGU...
      
      Philip Warner
      f7168bd4
    • Bruce Momjian's avatar
      I notice that contrib/fuzzystrmatch/dmetaphone.c doesn't compile cleanly · b43fd16e
      Bruce Momjian authored
      as it stands - it mixes declarations in code, C++-style. The attached
      patch shifts declarations to the tops of functions and enables this file
      to compile cleanly as C.
      
      Richard Poole
      b43fd16e
    • Bruce Momjian's avatar
      Add psql tab completion TODO: · a9ed7476
      Bruce Momjian authored
      < * -Have psql \dn show only visible temp schemas using current_schemas()
      < * -Have psql '\i ~/<tab><tab>' actually load files it displays from home dir
      484a483,484
      > * -Have psql \dn show only visible temp schemas using current_schemas()
      > * -Have psql '\i ~/<tab><tab>' actually load files it displays from home dir
      516a517,527
      >
      > * psql tab completion
      >
      > 	o Provide a list of conversions after ALTER CONVERSION?
      > 	o Support for ALTER SEQUENCE clauses
      > 	o Add RENAME TO to ALTER TRIGGER
      > 	o Support for ALTER USER
      > 	o Fix ALTER (GROUP|DOMAIN|...) <sth> DROP
      > 	o Support for ALTER LANGUAGE <sth> RENAME TO
      > 	o Improve support for COPY
      > 	o Improve support for ALTER TABLE
      a9ed7476
    • Bruce Momjian's avatar
      Attached is the third version of my patch that adds/fixes several things · cecf41bd
      Bruce Momjian authored
      to/in the psql-tabcomplete code. This diff includes the still missing
      tab-complete support for TABLESPACE I already sent earlier. New in this
      version of the patch is a small adaption of the tab-complete code to
      support the adjusted SAVEPOINT-Syntax commited by Tom, as well as
      completion of the only half working (and I think only by accident)
      tabcomplete-suppport for "BEGIN [ TRANSACTION | WORK ]".
      
      below is a complete list of the things I have changed with this patch:
      
      
      *) add tablespace support for CREATE/DROP/ALTER and \db
      *) sync the list of possible commands following ALTER with the docs (by
      adding
      AGGREGATE,CONVERSATION,DOMAIN,FUNCTION,LANGUAGE,OPERATOR,SEQUENCE,TABLESPACE
      and TYPE)
      *) provide a list of valid users after "OWNER TO"
      *) tab-complete support for ALTER (AGGREGATE|CONVERSION|FUNCTION)
      *) basic tab-complete support for ALTER DOMAIN
      *) provide a list of suitable indexes following ALTER TABLE <sth>
      CLUSTER ON(?)
      *) add "CLUSTER ON" and "SET" to the ALTER TABLE <sth> - tab-complete
      list(fixes incorrect/wrong tab-complete with ALTER TABLE <sth> SET
      +<TAB> too)
      *) provide a list of possible indexes following ALTER TABLE <sth> CLUSTER ON
      *) provide list of possible commands(WITHOUT CLUSTER,WITHOUT OIDS,
      TABLESPACE) following ALTER TABLE <sth> SET
      *) sync "COMMENT ON" with docs by adding "CAST","CONVERSION","FUNCTION"
      *) add ABSOLUT to the list of possible commands after FETCH
      *) "END" was missing from the sql-commands overview (though it had
      completion support!) - i know it's depreciated but we have ABORT and
      others still in ...
      *) fixes small buglet with ALTER (TRIGGER|CLUSTER) ON autocomplete
      (CLUSTER ON +<TAB> would produce CLUSTER ON ON - same for TRIGGER ON)
      *) adapt to new SAVEPOINT syntax
      *) fix incomplete Support for BEGIN [ TRANSACTION | WORK ]
      
      Stefan Kaltenbrunn
      cecf41bd
    • Bruce Momjian's avatar
      This patch allows pg_restore to recognize $-quotes in SQL queries. It · 1b5e0143
      Bruce Momjian authored
      will treat any unquoted string that starts with a $ and has no preceding
      identifier chars as a potential $-quote tag, it then makes sure that the
      tag chars are valid. If so, it processes the $-quote.
      
      Philip Warner
      1b5e0143
    • Bruce Momjian's avatar
      Add mention of environment variable conflict with uncommenting config · fcc5b95e
      Bruce Momjian authored
      file variables:
      
      <   Another option is to allow commented values to return to their
      <   default values.
      >   This has to address environment variables that are then overridden
      >   by config file values.  Another option is to allow commented values
      >   to return to their default values.
      fcc5b95e