1. 15 Sep, 2015 5 commits
    • Tom Lane's avatar
      Revert "Fix an O(N^2) problem in foreign key references". · 3d9e8db9
      Tom Lane authored
      Commit 5ddc7288 does not actually work
      because it will happily blow away ri_constraint_cache entries that are
      in active use in outer call levels.  In any case, it's a very ugly,
      brute-force solution to the problem of limiting the cache size.
      Revert until it can be redesigned.
      3d9e8db9
    • Stephen Frost's avatar
      Add POLICY to COMMENT documentation · 6820094d
      Stephen Frost authored
      COMMENT supports POLICY but the documentation hadn't caught up with
      that fact.
      
      Patch by Charles Clavadetscher
      
      Back-patch to 9.5 where POLICY was added.
      6820094d
    • Fujii Masao's avatar
      05ec71ee
    • Fujii Masao's avatar
      Improve log messages related to tablespace_map file · 10fbb79f
      Fujii Masao authored
      This patch changes the log message which is logged when the server
      successfully renames backup_label file to *.old but fails to rename
      tablespace_map file during the shutdown. Previously the WARNING
      message "online backup mode was not canceled" was logged in that case.
      However this message is confusing because the backup mode is treated
      as canceled whenever backup_label is successfully renamed. So this
      commit makes the server log the message "online backup mode canceled"
      in that case.
      
      Also this commit changes errdetail messages so that they follow the
      error message style guide.
      
      Back-patch to 9.5 where tablespace_map file is introduced.
      
      Original patch by Amit Kapila, heavily modified by me.
      10fbb79f
    • Teodor Sigaev's avatar
      Fix wrong comment in commit d0242602 · 0f759285
      Teodor Sigaev authored
      Per gripe from Robert Haas
      0f759285
  2. 14 Sep, 2015 1 commit
  3. 13 Sep, 2015 3 commits
  4. 12 Sep, 2015 2 commits
  5. 11 Sep, 2015 8 commits
    • Robert Haas's avatar
      Install lwlocknames.h even in vpath builds. · a7212a99
      Robert Haas authored
      Per buildfarm member crake.
      a7212a99
    • Bruce Momjian's avatar
      pg_dump, pg_upgrade: allow postgres/template1 tablespace moves · 7f8d090b
      Bruce Momjian authored
      Modify pg_dump to restore postgres/template1 databases to non-default
      tablespaces by switching out of the database to be moved, then switching
      back.
      
      Also, to fix potentially cases where the old/new tablespaces might not
      match, fix pg_upgrade to process new/old tablespaces separately in all
      cases.
      
      Report by Marti Raudsepp
      
      Patch by Marti Raudsepp, me
      
      Backpatch through 9.0
      7f8d090b
    • Robert Haas's avatar
      Fix build problems in commit aa65de04. · 2ccc4e97
      Robert Haas authored
      The previous way didn't work for vpath builds, and make distprep was
      busted too.
      
      Reported off-list by Andres Freund.
      2ccc4e97
    • Alvaro Herrera's avatar
      Add missing ReleaseBuffer call in BRIN revmap code · 5cd65383
      Alvaro Herrera authored
      I think this particular branch is actually dead, but the analysis to
      prove that is not trivial, so instead take the weasel way.
      
      Reported by Jinyu Zhang
      Backpatch to 9.5, where BRIN was introduced.
      5cd65383
    • Kevin Grittner's avatar
      Fix an O(N^2) problem in foreign key references. · 5ddc7288
      Kevin Grittner authored
      Commit 45ba424f improved foreign key lookups during bulk updates
      when the FK value does not change.  When restoring a schema dump
      from a database with many (say 100,000) foreign keys, this cache
      would grow very big and every ALTER TABLE command was causing an
      InvalidateConstraintCacheCallBack(), which uses a sequential hash
      table scan.  This could cause a severe performance regression in
      restoring a schema dump (including during pg_upgrade).
      
      The patch uses a heuristic method of detecting when the hash table
      should be destroyed and recreated.
      InvalidateConstraintCacheCallBack() adds the current size of the
      hash table to a counter.  When that sum reaches 1,000,000, the hash
      table is flushed.  This fixes the regression without noticeable
      harm to the bulk update use case.
      
      Jan Wieck
      Backpatch to 9.3 where the performance regression was introduced.
      5ddc7288
    • Robert Haas's avatar
      When trace_lwlocks is used, identify individual lwlocks by name. · aa65de04
      Robert Haas authored
      Naming the individual lwlocks seems like something that may be useful
      for other types of debugging, monitoring, or instrumentation output,
      but this commit just implements it for the specific case of
      trace_lwlocks.
      
      Patch by me, reviewed by Amit Kapila and Kyotaro Horiguchi
      aa65de04
    • Fujii Masao's avatar
      Correct description of PageHeaderData layout in documentation · a1b28885
      Fujii Masao authored
      Back-patch to 9.3 where PageHeaderData layout was changed.
      
      Michael Paquier
      a1b28885
    • Peter Eisentraut's avatar
      doc: Spell checking · 103ef202
      Peter Eisentraut authored
      103ef202
  6. 10 Sep, 2015 3 commits
    • Tom Lane's avatar
      Fix setrefs.c comment properly. · 87efbc2b
      Tom Lane authored
      The "typo" alleged in commit 1e460d4b was actually a comment that was
      correct when written, but I missed updating it in commit b5282aa8.
      Use a slightly less specific (and hopefully more future-proof) description
      of what is collected.  Back-patch to 9.2 where that commit appeared, and
      revert the comment to its then-entirely-correct state before that.
      87efbc2b
    • Stephen Frost's avatar
      Fix typo in setrefs.c · 1e460d4b
      Stephen Frost authored
      We're adding OIDs, not TIDs, to invalItems.
      
      Pointed out by Etsuro Fujita.
      
      Back-patch to all supported branches.
      1e460d4b
    • Tom Lane's avatar
      Fix minor bug in regexp makesearch() function. · 91cf3135
      Tom Lane authored
      The list-wrangling here was done wrong, allowing the same state to get
      put into the list twice.  The following loop then would clone it twice.
      The second clone would wind up with no inarcs, so that there was no
      observable misbehavior AFAICT, but a useless state in the finished NFA
      isn't an especially good thing.
      91cf3135
  7. 09 Sep, 2015 3 commits
    • Teodor Sigaev's avatar
      Fix oversight in 013ebc0a commit · 223936e2
      Teodor Sigaev authored
      Declaration of varibale inside ÓÝ×Õ
      223936e2
    • Teodor Sigaev's avatar
      Microvacuum for GIST · 013ebc0a
      Teodor Sigaev authored
      Mark index tuple as dead if it's pointed by kill_prior_tuple during
      ordinary (search) scan and remove it during insert process if there is no
      enough space for new tuple to insert. This improves select performance
      because index will not return tuple marked as dead and improves insert
      performance because it reduces number of page split.
      
      Anastasia Lubennikova <a.lubennikova@postgrespro.ru> with
       minor editorialization by me
      013ebc0a
    • Fujii Masao's avatar
      Remove files signaling a standby promotion request at postmaster startup · 96f6a0cb
      Fujii Masao authored
      This commit makes postmaster forcibly remove the files signaling
      a standby promotion request. Otherwise, the existence of those files
      can trigger a promotion too early, whether a user wants that or not.
      
      This removal of files is usually unnecessary because they can exist
      only during a few moments during a standby promotion. However
      there is a race condition: if pg_ctl promote is executed and creates
      the files during a promotion, the files can stay around even after
      the server is brought up to new master. Then, if new standby starts
      by using the backup taken from that master, the files can exist
      at the server startup and should be removed in order to avoid
      an unexpected promotion.
      
      Back-patch to 9.1 where promote signal file was introduced.
      
      Problem reported by Feike Steenbergen.
      Original patch by Michael Paquier, modified by me.
      
      Discussion: 20150528100705.4686.91426@wrigleys.postgresql.org
      96f6a0cb
  8. 08 Sep, 2015 7 commits
  9. 07 Sep, 2015 8 commits
    • Noah Misch's avatar
      In the pg_rewind test suite, receive WAL fully before promoting. · 582fbffb
      Noah Misch authored
      If a transaction never reaches the standby, later tests find unexpected
      cluster state.  A "tail-copy: query result matches" test failure has
      been the usual symptom.  Among the buildfarm members having run this
      test suite, most have exhibited that symptom at least once.  Back-patch
      to 9.5, where pg_rewind was introduced.
      
      Michael Paquier, reported by Christoph Berg.
      582fbffb
    • Jeff Davis's avatar
      Coordinate log_line_prefix options 'm' and 'n' to share a timeval. · b1e1862a
      Jeff Davis authored
      Commit f828654e introduced the 'n' option, but it invoked
      gettimeofday() independently of the 'm' option. If both options were
      in use (or multiple 'n' options), or if 'n' was in use along with
      csvlog, then the reported times could be different for the same log
      message.
      
      To fix, initialize a global variable with gettimeofday() once per log
      message, and use that for both formats.
      
      Don't bother coordinating the time for the 't' option, which has much
      lower resolution.
      
      Per complaint by Alvaro Herrera.
      b1e1862a
    • Alvaro Herrera's avatar
      Add more sanity checks in contrib/sslinfo · d94c36a4
      Alvaro Herrera authored
      We were missing a few return checks on OpenSSL calls.  Should be pretty
      harmless, since we haven't seen any user reports about problems, and
      this is not a high-traffic module anyway; still, a bug is a bug, so
      backpatch this all the way back to 9.0.
      
      Author: Michael Paquier, while reviewing another sslinfo patch
      d94c36a4
    • Jeff Davis's avatar
      Add log_line_prefix option 'n' for Unix epoch. · f828654e
      Jeff Davis authored
      Prints time as Unix epoch with milliseconds.
      
      Tomas Vondra, reviewed by Fabien Coelho.
      f828654e
    • Greg Stark's avatar
      Change type of DOW/DOY to UNITS · 37239ef8
      Greg Stark authored
      37239ef8
    • Teodor Sigaev's avatar
      Make GIN's cleanup pending list process interruptable · e2669224
      Teodor Sigaev authored
      Cleanup process could be called by ordinary insert/update and could take a lot
      of time. Add vacuum_delay_point() to make this process interruptable. Under
      vacuum this call will also throttle a vacuum process to decrease system load,
      called from insert/update it will not throttle, and that reduces a latency.
      
      Backpatch for all supported branches.
      
      Jeff Janes <jeff.janes@gmail.com>
      e2669224
    • Teodor Sigaev's avatar
      Add pages deleted from pending list to FSM · e9568083
      Teodor Sigaev authored
      Add pages deleted from GIN's pending list during cleanup to free space map
      immediately. Clean up process could be initiated by ordinary insert but adding
      page to FSM might occur only at vacuum. On some workload like never-vacuumed
      insert-only tables it could cause a huge bloat.
      
      Jeff Janes <jeff.janes@gmail.com>
      e9568083
    • Teodor Sigaev's avatar
      Update site address of Snowball project · a1c44e1a
      Teodor Sigaev authored
      a1c44e1a