1. 10 May, 2011 6 commits
  2. 09 May, 2011 3 commits
  3. 08 May, 2011 3 commits
  4. 07 May, 2011 6 commits
  5. 06 May, 2011 3 commits
    • Peter Eisentraut's avatar
      Improve compiler string shown in version() · 8dd2ede3
      Peter Eisentraut authored
      With some compilers such as Clang and ICC emulating GCC, using a
      version string of the form "GCC $version" can be quite misleading.
      Also, a great while ago, the version output from gcc --version started
      including the string "gcc", so it is redundant to repeat that.  In
      order to support ancient GCC versions, we now prefix the result with
      "GCC " only if the version output does not start with a letter.
      8dd2ede3
    • Tom Lane's avatar
      Move RegisterPredicateLockingXid() call to a safer place. · d2088ae9
      Tom Lane authored
      The SSI patch inserted a call of RegisterPredicateLockingXid into
      GetNewTransactionId, which was a bad idea on a couple of grounds.  First,
      it's not necessary to hold XidGenLock while manipulating that shared
      memory, and doing so is bad because XidGenLock is a high-contention lock
      that should be held for as short a time as possible.  (Not to mention that
      it adds an entirely unnecessary deadlock hazard, since we must take
      SerializableXactHashLock as well.)  Second, the specific place where it was
      put was between extending CLOG and advancing nextXid, which could result in
      unpleasant behavior in case of a failure there.  Pull the call out to
      AssignTransactionId, which is much safer and arguably better from a
      modularity standpoint too.
      
      There is more work to do to clean up the failure-before-advancing-nextXid
      issue, but that is a separate change that will need to be back-patched.
      So for the moment I just want to make GetNewTransactionId look the same as
      it did in prior versions.
      d2088ae9
    • Tom Lane's avatar
      Remove precedence labeling of keywords TRUE, FALSE, UNKNOWN, and ZONE. · 12b71645
      Tom Lane authored
      These were labeled with precedences just to avoid attaching explicit
      precedences to the productions in which they were the last terminal symbol.
      Since a terminal symbol precedence marking can affect many other things
      too, it seems like better practice to attach precedence labels to the
      productions, and not mark the terminal symbols.
      
      Ideally we'd also remove the precedence attached to NULL_P, but it turns
      out that we are actually depending on that having a precedence higher than
      POSTFIXOP, else we get a shift/reduce conflict for postfix operators in
      b_expr.  (Which more or less proves my point about these markings having a
      high risk of unexpected consequences.)  For the moment, move NULL_P into
      the set of keywords grouped with IDENT, so that at least it will act
      similarly to non-keywords; and document the interaction.
      12b71645
  6. 05 May, 2011 5 commits
  7. 04 May, 2011 5 commits
  8. 03 May, 2011 2 commits
  9. 02 May, 2011 5 commits
    • Alvaro Herrera's avatar
      Add ID attribute to some sect2's missing it · 155743ad
      Alvaro Herrera authored
      David Fetter
      155743ad
    • Tom Lane's avatar
      Fix pull_up_sublinks' failure to handle nested pull-up opportunities. · dcc685de
      Tom Lane authored
      After finding an EXISTS or ANY sub-select that can be converted to a
      semi-join or anti-join, we should recurse into the body of the sub-select.
      This allows cases such as EXISTS-within-EXISTS to be optimized properly.
      The original coding would leave the lower sub-select as a SubLink, which
      is no better and often worse than what we can do with a join.  Per example
      from Wayne Conrad.
      
      Back-patch to 8.4.  There is a related issue in older versions' handling
      of pull_up_IN_clauses, but they're lame enough anyway about the whole area
      that it seems not worth the extra work to try to fix.
      dcc685de
    • Alvaro Herrera's avatar
      Update some ALTER USER cross-references to ALTER ROLE · 52897e54
      Alvaro Herrera authored
      Greg Smith
      52897e54
    • Peter Eisentraut's avatar
      4b08bf8c
    • Tom Lane's avatar
      Improve aset.c's space management in contexts with small maxBlockSize. · 6755558b
      Tom Lane authored
      The previous coding would allow requests up to half of maxBlockSize to be
      treated as "chunks", but when that actually did happen, we'd waste nearly
      half of the space in the malloc block containing the chunk, if no smaller
      requests came along to fill it.  Avoid this scenario by limiting the
      maximum size of a chunk to 1/8th maxBlockSize, so that we can waste no more
      than 1/8th of the allocated space.  This will not change the behavior at
      all for the default context size parameters (with large maxBlockSize),
      but it will change the behavior when using ALLOCSET_SMALL_MAXSIZE.
      
      In particular, there's no longer a need for spell.c to be overly concerned
      about the request size parameters it uses, so remove a rather unhelpful
      comment about that.
      
      Merlin Moncure, per an idea of Tom Lane's
      6755558b
  10. 01 May, 2011 2 commits
    • Peter Eisentraut's avatar
      Catch errors in for loop in makefile · 5c436a79
      Peter Eisentraut authored
      Add "|| exit" so that the rule aborts when a command fails.
      5c436a79
    • Peter Eisentraut's avatar
      Rewrite installation makefile rules without for loops · b106195b
      Peter Eisentraut authored
      install-sh can install multiple files at once, so for loops are not
      necessary.  This was already changed for the rest of the code some
      time ago, but pgxs.mk was apparently forgotten, and the obsolete
      coding style has now been copied to the PLs as well.
      
      This also fixes the problem that the for loops in question did not
      catch errors.
      b106195b