1. 16 Aug, 2002 10 commits
  2. 15 Aug, 2002 16 commits
    • Bruce Momjian's avatar
      Done: · 52f8c56a
      Bruce Momjian authored
      > 	o -Prevent loss of indexes, permissions, inheritance
      52f8c56a
    • Bruce Momjian's avatar
      Done: · ea1954fc
      Bruce Momjian authored
      > * -Improve control over user privileges, including table creation
      > * -Add PGPASSWORDFILE environment variable or ~/.pgpass to store
      > 	o -Compile under jdk 1.4
      ea1954fc
    • Bruce Momjian's avatar
      Tom Lane wrote: · b1a5f872
      Bruce Momjian authored
      > There's no longer a separate call to heap_storage_create in that routine
      > --- the right place to make the test is now in the storage_create
      > boolean parameter being passed to heap_create.  A simple change, but
      > it passeth patch's understanding ...
      
      Thanks.
      
      Attached is a patch against cvs tip as of 8:30 PM PST or so. Turned out
      that even after fixing the failed hunks, there was a new spot in
      bufmgr.c which needed to be fixed (related to temp relations;
      RelationUpdateNumberOfBlocks). But thankfully the regression test code
      caught it :-)
      
      Joe Conway
      b1a5f872
    • Bruce Momjian's avatar
      38294db6
    • Bruce Momjian's avatar
      This fixes some text as well as enforces the use of "drop table cascade" · 1991fe74
      Bruce Momjian authored
      since we moved from an implicate to explicate implementation.
      
      
      Greg Copeland
      1991fe74
    • Bruce Momjian's avatar
      Well, that certainly appeared to be very straight forward. pg.py and · 4f1ac055
      Bruce Momjian authored
      syscat.py scripts were both modified.  pg.py uses it to cache a list of
      pks (which is seemingly does for every db connection) and various
      attributes.  syscat uses it to walk the list of system tables and
      queries the various attributes from these tables.
      
      In both cases, it seemingly makes sense to apply what you've requested.
      
      Greg Copeland
      4f1ac055
    • Bruce Momjian's avatar
      http://archives.postgresql.org/pgsql-bugs/2002-06/msg00086.php and never · 147aa84c
      Bruce Momjian authored
      saw a fix offered up.  Since I'm gearing up to use Postgres and Python
      soon, I figured I'd have a hand at trying to get this sucker addressed.
      Apologies if this has already been plugged.  I looked in the archives
      and never saw a response.
      
      At any rate, I must admit I don't think I fully understand the
      implications of some of the changes I made even though they appear to be
      straight forward.  We all know the devil is in the details.  Anyone more
      knowledgeable is requested to review my changes. :(
      
      I also updated the advanced.py script in a somewhat nonsensical fashion
      to make use of an int8 field in an effort to test this change.  It seems
      to run okay, however, this is by no means an all exhaustive test.  So,
      it's possible that a bumpy road may lay ahead for some.  On the other
      hand...overflows (hopefully) previously lurked (long -> int conversion).
      
      Greg Copeland
      147aa84c
    • Bruce Momjian's avatar
      Backed out. It is part of a later patch. · db147006
      Bruce Momjian authored
      db147006
    • Bruce Momjian's avatar
      August 13, 2002 · 2860041b
      Bruce Momjian authored
               Use parser of OpenFTS v0.33.
      
      --
      Teodor Sigaev
      2860041b
    • Bruce Momjian's avatar
      PostgreSQL 7.2.1 Documentation · 12763562
      Bruce Momjian authored
      Chapter 1. libpq - C Library
      1.3. Command Execution Functions
      1.3.3. Escaping binary strings for inclusion in SQL queries
      
      I found the line
      "The result string length does not include the terminating zero byte of the result."
      is not right.
      The result string length does indeed include the terminating zero byte.
      
      Christoph Haller
      12763562
    • Bruce Momjian's avatar
      > Neil Conway <nconway@klamath.dyndns.org> writes: · 88bd3068
      Bruce Momjian authored
      > > This patch improves the documentation of the UPDATE and ALTER TABLE
      > > commands to elaborate on the effect of specifying an "ONLY" clause.
      >
      > Unfortunately this is still only half the truth ... see the
      > SQL_INHERITANCE configuration variable.
      
      Okay, I've attached an updated patch with more information on
      SQL_INHERITANCE and inheritance behavior in prior releases.
      
      Neil Conway
      88bd3068
    • Bruce Momjian's avatar
      The attached patch changes most of the usages of sprintf() to · 66eb8df6
      Bruce Momjian authored
      snprintf() in contrib/. I didn't touch the places where pointer
      arithmatic was being used, or other areas where the fix wasn't
      trivial. I would think that few, if any, of the usages of sprintf()
      were actually exploitable, but it's probably better to be paranoid...
      
      Neil Conway
      66eb8df6
    • Bruce Momjian's avatar
      I'm giving a try at some TODO items. Currently it's the turn of the · 7f4981f4
      Bruce Momjian authored
      PGPASSWORDFILE environment variable.  I have modified libpq to make use
      of this variable.  I present the first cut here.
      
      Currently the format for the file should be
      
      host:port:database:user:password
      
      Alvaro Herrera
      7f4981f4
    • Bruce Momjian's avatar
      Appears there is a problem finding the opclass when indexing a domain. · 46aaa5dd
      Bruce Momjian authored
      CREATE DOMAIN newint as int4;
      CREATE TABLE tab (col newint unique);
      ERROR:  data type newint has no default operator class for access method
      "btree"
              You must specify an operator class for the index or define a
              default operator class for the data type
      
      
      Specifically, GetDefaultOpClass() finds 0 exact matches and 3 binary
      compatible matches.  Fetching getBaseType() of the attribute fixes the
      problem for domains (see attachment).
      
      Rod Taylor
      46aaa5dd
    • Bruce Momjian's avatar
      As discussed on several occasions previously, the new anonymous · 45e25445
      Bruce Momjian authored
      composite type capability makes it possible to create a system view
      based on a table function in a way that is hopefully palatable to
      everyone. The attached patch takes advantage of this, moving
      show_all_settings() from contrib/tablefunc into the backend (renamed
      all_settings(). It is defined as a builtin returning type RECORD. During
      initdb a system view is created to expose the same information presently
      available through SHOW ALL. For example:
      
      test=# select * from pg_settings where name like '%debug%';
                name          | setting
      -----------------------+---------
        debug_assertions      | on
        debug_pretty_print    | off
        debug_print_parse     | off
        debug_print_plan      | off
        debug_print_query     | off
        debug_print_rewritten | off
        wal_debug             | 0
      (7 rows)
      
      
      Additionally during initdb two rules are created which make it possible
      to change settings by updating the system view -- a "virtual table" as
      Tom put it. Here's an example:
      
      Joe Conway
      45e25445
    • Bruce Momjian's avatar
      The second enables tab-complete to analyze. It ignores schema stuff (so · 4c4854c4
      Bruce Momjian authored
      does every tab-completion command AFAICS)
      
      Alvaro Herrera
      4c4854c4
  3. 14 Aug, 2002 14 commits
    • Tom Lane's avatar
      dc870553
    • Bruce Momjian's avatar
      Enable encrypted passwords by default. · b20f80f0
      Bruce Momjian authored
      b20f80f0
    • Barry Lind's avatar
      Added support for JDBC3. The driver will now build under JDBC3 (i.e. Java 1.4). · b3dd55c6
      Barry Lind authored
      This concludes my changes that restructured the code to support JDBC3.
      The jdbc unit tests were also resturctured to allow different tests between
      jdbc2 and jdbc3, although currently make check (aka ant test) for JDBC3 just
      runs the JDBC2 tests.  Of special note the largeobject/PGblob and PGclob
      classes have been moved under the jdbc2/jdbc3 specific directories as they
      now differ by jdbc version.  Also note that this checkin removes the
      PostgresqlDataSource and files in the xa directory.  A recent checkin has
      added new datasource support that replaces the functionality provided by these
      classes.
      
       Modified Files:
       	jdbc/build.xml
       	jdbc/org/postgresql/jdbc1/AbstractJdbc1DatabaseMetaData.java
       	jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
       	jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSetMetaData.java
       	jdbc/org/postgresql/jdbc1/AbstractJdbc1Statement.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2Connection.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2DatabaseMetaData.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSet.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2ResultSetMetaData.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2Statement.java
       	jdbc/org/postgresql/jdbc2/Array.java
       	jdbc/org/postgresql/jdbc2/Jdbc2CallableStatement.java
       	jdbc/org/postgresql/jdbc2/Jdbc2Connection.java
       	jdbc/org/postgresql/jdbc2/Jdbc2DatabaseMetaData.java
       	jdbc/org/postgresql/jdbc2/Jdbc2PreparedStatement.java
       	jdbc/org/postgresql/jdbc2/Jdbc2ResultSet.java
       	jdbc/org/postgresql/jdbc2/Jdbc2ResultSetMetaData.java
       	jdbc/org/postgresql/jdbc2/Jdbc2Statement.java
       	jdbc/org/postgresql/test/jdbc2/BatchExecuteTest.java
       	jdbc/org/postgresql/test/jdbc2/BlobTest.java
       	jdbc/org/postgresql/test/jdbc2/CallableStmtTest.java
       	jdbc/org/postgresql/test/jdbc2/ConnectionTest.java
       	jdbc/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
       	jdbc/org/postgresql/test/jdbc2/DateTest.java
       	jdbc/org/postgresql/test/jdbc2/DriverTest.java
       	jdbc/org/postgresql/test/jdbc2/JBuilderTest.java
       	jdbc/org/postgresql/test/jdbc2/MiscTest.java
       	jdbc/org/postgresql/test/jdbc2/ResultSetTest.java
       	jdbc/org/postgresql/test/jdbc2/TimeTest.java
       	jdbc/org/postgresql/test/jdbc2/TimestampTest.java
       	jdbc/org/postgresql/test/jdbc2/UpdateableResultTest.java
       Added Files:
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2Blob.java
       	jdbc/org/postgresql/jdbc2/AbstractJdbc2Clob.java
       	jdbc/org/postgresql/jdbc2/Jdbc2Blob.java
       	jdbc/org/postgresql/jdbc2/Jdbc2Clob.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3Blob.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3Clob.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3Connection.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3DatabaseMetaData.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3ResultSet.java
       	jdbc/org/postgresql/jdbc3/AbstractJdbc3Statement.java
       	jdbc/org/postgresql/jdbc3/Jdbc3Blob.java
       	jdbc/org/postgresql/jdbc3/Jdbc3CallableStatement.java
       	jdbc/org/postgresql/jdbc3/Jdbc3Clob.java
       	jdbc/org/postgresql/jdbc3/Jdbc3Connection.java
       	jdbc/org/postgresql/jdbc3/Jdbc3DatabaseMetaData.java
       	jdbc/org/postgresql/jdbc3/Jdbc3PreparedStatement.java
       	jdbc/org/postgresql/jdbc3/Jdbc3ResultSet.java
       	jdbc/org/postgresql/jdbc3/Jdbc3ResultSetMetaData.java
       	jdbc/org/postgresql/jdbc3/Jdbc3Statement.java
       	jdbc/org/postgresql/test/TestUtil.java
       	jdbc/org/postgresql/test/jdbc2/Jdbc2TestSuite.java
       	jdbc/org/postgresql/test/jdbc3/Jdbc3TestSuite.java
       Removed Files:
       	jdbc/org/postgresql/PostgresqlDataSource.java
       	jdbc/org/postgresql/largeobject/PGblob.java
       	jdbc/org/postgresql/largeobject/PGclob.java
       	jdbc/org/postgresql/test/JDBC2Tests.java
       	jdbc/org/postgresql/xa/ClientConnection.java
       	jdbc/org/postgresql/xa/TwoPhaseConnection.java
       	jdbc/org/postgresql/xa/TxConnection.java
       	jdbc/org/postgresql/xa/XAConnectionImpl.java
       	jdbc/org/postgresql/xa/XADataSourceImpl.java
      b3dd55c6
    • Bruce Momjian's avatar
      Update text: · 64a06494
      Bruce Momjian authored
      < 	o Allow PL/PgSQL function parameters to be passed by name,
      > 	o Allow function parameters to be passed by name,
      64a06494
    • Bruce Momjian's avatar
      Update: · 5b743090
      Bruce Momjian authored
      > 	o Cluster all tables at once using pg_index.indisclustered set during
      >           previous CLUSTER
      5b743090
    • Bruce Momjian's avatar
      I guess I'd vote for changing the code to be · dec91847
      Bruce Momjian authored
              sys = malloc(strlen(editorName) + strlen(fname) + 10 + 1);
              if (!sys)
                      return false;
              sprintf(sys, "exec '%s' '%s'", editorName, fname);
      
      (note the added quotes to provide a little protection against spaces
      and such).  Then it's perfectly obvious what the calculation is doing.
      I don't care about wasting 20-some bytes, but confusing readers of the
      code is worth avoiding.
      
                              regards, tom lane
      dec91847
    • Tatsuo Ishii's avatar
      Fix memory leak in SetClientEncoding(). · 538b1015
      Tatsuo Ishii authored
      538b1015
    • Bruce Momjian's avatar
      Add: · fcbc87c1
      Bruce Momjian authored
      > 	o Add ALTER TABLE tab SET WITHOUT OIDS
      fcbc87c1
    • Bruce Momjian's avatar
      Oops, not done: · 561e25ad
      Bruce Momjian authored
      > * Have views on temporary tables exist in the temporary namespace
      561e25ad
    • Bruce Momjian's avatar
      Updated: · 596ba5ec
      Bruce Momjian authored
      < * Allow temporary views
      < * Require view using temporary tables to be temporary views
      > * -Have views on temporary tables exist in the temporary namespace
      596ba5ec
    • Bruce Momjian's avatar
      Spacing improvement. · 106c733c
      Bruce Momjian authored
      106c733c
    • Bruce Momjian's avatar
      Fix spacing. · 293ab5ab
      Bruce Momjian authored
      293ab5ab
    • Bruce Momjian's avatar
      Added: · 9f19f3c8
      Bruce Momjian authored
      <
      > 	o Improve PL/PgSQL exception handling
      > 	o Allow PL/PgSQL parameters to be specified by name and type during
      > 	  definition
      > 	o Allow PL/PgSQL function parameters to be passed by name,
      > 	  get_employee_salary(emp_id => 12345, tax_year => 2001)
      > 	o Add PL/PgSQL packages
      > 	o Allow array declarations and other data types in PL/PgSQl DECLARE
      > 	o Add PL/PgSQL PROCEDURES that can return multiple values
      9f19f3c8
    • Tatsuo Ishii's avatar
      Add Cyrillic and other encodings for encoding conversion. · 969e0246
      Tatsuo Ishii authored
      Patches submitted by Kaori Inaba (i-kaori@sra.co.jp).
      969e0246