1. 31 Mar, 2008 2 commits
    • Tom Lane's avatar
      Use error message wordings for permissions checks on .pgpass and SSL private · 3405f2b9
      Tom Lane authored
      key files that are similar to the one for the postmaster's data directory
      permissions check.  (I chose to standardize on that one since it's the most
      heavily used and presumably best-wordsmithed by now.)  Also eliminate explicit
      tests on file ownership in these places, since the ensuing read attempt must
      fail anyway if it's wrong, and there seems no value in issuing the same error
      message for distinct problems.  (But I left in the explicit ownership test in
      postmaster.c, since it had its own error message anyway.)  Also be more
      specific in the documentation's descriptions of these checks.  Per a gripe
      from Kevin Hunter.
      3405f2b9
    • Tom Lane's avatar
      Fix a number of places that were making file-type tests infelicitously. · c5f11f9d
      Tom Lane authored
      The places that did, eg,
      	(statbuf.st_mode & S_IFMT) == S_IFDIR
      were correct, but there is no good reason not to use S_ISDIR() instead,
      especially when that's what the other 90% of our code does.  The places
      that did, eg,
      	(statbuf.st_mode & S_IFDIR)
      were flat out *wrong* and would fail in various platform-specific ways,
      eg a symlink could be mistaken for a regular file on most Unixen.
      
      The actual impact of this is probably small, since the problem cases
      seem to always involve symlinks or sockets, which are unlikely to be
      found in the directories that PG code might be scanning.  But it's
      clearly trouble waiting to happen, so patch all the way back anyway.
      (There seem to be no occurrences of the mistake in 7.4.)
      c5f11f9d
  2. 30 Mar, 2008 3 commits
  3. 29 Mar, 2008 3 commits
  4. 28 Mar, 2008 6 commits
  5. 27 Mar, 2008 7 commits
  6. 26 Mar, 2008 10 commits
  7. 25 Mar, 2008 9 commits