- 20 Jan, 2010 7 commits
-
-
Heikki Linnakangas authored
walreceiver as whole into a dynamically loaded module, split the libpq-specific parts of it into dynamically loaded module and keep the rest in the main backend binary. Although Tom fixed the Windows compilation problems with the old walreceiver module already, this is a cleaner division of labour and makes the code more readable. There's also the prospect of adding new transport methods as pluggable modules in the future, which this patch makes easier, though for now the API between libpqwalreceiver and walreceiver process should be considered private. The libpq-specific module is now in src/backend/replication/libpqwalreceiver, and the part linked with postgres binary is in src/backend/replication/walreceiver.c.
-
Peter Eisentraut authored
name already exists, so we'd get an error message about a "type" instead of about a "relation", because the composite type code shares code with relation creation.
-
Andrew Dunstan authored
-
Andrew Dunstan authored
-
Robert Haas authored
-
Andrew Dunstan authored
quote_literal, quote_nullable, quote_ident, encode_bytea, decode_bytea, looks_like_number, encode_array_literal, encode_array_constructor. Split SPI.xs into two - SPI.xs now contains only SPI functions. Remainder are in new Util.xs. Some more code and documentation cleanup along the way, as well as adding some CVS markers to files missing them. Original patch from Tim Bunce, with a little editing from me.
-
Robert Haas authored
Modify the "Escaping Strings for Inclusion in SQL Commands" section to use a <variablelist> as the preceding and following sections do, and merge the "Escaping Binary Strings for Inclusion in SQL Commands" section into it. This changes only the formatting of these sections, not the content. It is intended to lay the groundwork for a follow-on patch to add some new escaping functions, but it makes sense to commit this first, for clarity.
-
- 19 Jan, 2010 5 commits
-
-
Tom Lane authored
dump IDs, because the array we're using is sized according to the highest dump ID actually defined in the archive file. In a partial dump there could be references to higher dump IDs that weren't dumped. Treat these the same as references to in-range IDs that weren't dumped. (The whole thing is a bit scary because the missing objects might have been part of dependency chains, which we won't know about. Not much we can do though --- throwing an error is probably overreaction.) Also, reject parallel restore with pre-1.8 archive version (made by pre-8.0 pg_dump). In these old versions the dependency entries are OIDs, not dump IDs, and we don't have enough information to interpret them. Per bug #5288 from Jon Erdman.
-
Tom Lane authored
when the planner splits apart a ROW(...) IS NULL test, the argisrow values of the component tests have to be determined from the component field types, not copied from the original NullTest (in which argisrow is surely true).
-
Magnus Hagander authored
statistics of the bgwriter. Greg Smith
-
Tom Lane authored
wrappers around the pg_relation_size() function. Bernd Helmle, reviewed by Greg Smith
-
Tom Lane authored
This is the last EXECUTE-like plpgsql statement that was missing the capability of inserting parameter values via USING. Pavel Stehule, reviewed by Itagaki Takahiro
-
- 18 Jan, 2010 5 commits
-
-
Peter Eisentraut authored
cases that are not part of the enum's definition.
-
Tom Lane authored
EXISTS that contains a WITH clause. This would usually lead to a "could not find CTE" error later in planning, because the WITH wouldn't get processed at all. Noted while playing with an example from Ken Marshall.
-
Teodor Sigaev authored
Vyacheslav Kalinin <vka@mgcp.com>
-
Tom Lane authored
after it's released its reference count for the cached plan. There are code paths that might try to examine the plan list before noticing that the portal is already in aborted state. Report and diagnosis by Tatsuo Ishii, though this isn't exactly his proposed patch.
-
Tom Lane authored
constraints and was lacking a couple of other interesting details.
-
- 17 Jan, 2010 4 commits
-
-
Tom Lane authored
pg_constraint before searching pg_trigger. This allows saner handling of corner cases; in particular we now say "constraint is not deferrable" rather than "constraint does not exist" when the command is applied to a constraint that's inherently non-deferrable. Per a gripe several months ago from hubert depesz lubaczewski. To make this work without breaking user-defined constraint triggers, we have to add entries for them to pg_constraint. However, in return we can remove the pgconstrname column from pg_constraint, which represents a fairly sizable space savings. I also replaced the tgisconstraint column with tgisinternal; the old meaning of tgisconstraint can now be had by testing for nonzero tgconstraint, while there is no other way to get the old meaning of nonzero tgconstraint, namely that the trigger was internally generated rather than being user-created. In passing, fix an old misstatement in the docs and comments, namely that pg_trigger.tgdeferrable is exactly redundant with pg_constraint.condeferrable. Actually, we mark RI action triggers as nondeferrable even when they belong to a nominally deferrable FK constraint. The SET CONSTRAINTS code now relies on that instead of hard-coding a list of exception OIDs.
-
Magnus Hagander authored
-
Magnus Hagander authored
-
Tom Lane authored
-
- 16 Jan, 2010 12 commits
-
-
Magnus Hagander authored
-
Tom Lane authored
posix_fadvise and other file-related functions can depend on _LARGEFILE_SOURCE and/or _FILE_OFFSET_BITS. Per report from Robert Treat. Back-patch to 8.4. This has been wrong all along, but we weren't really using posix_fadvise in anger before, and AC_FUNC_FSEEKO seems to mask the issue well enough for that function.
-
Tom Lane authored
argument, per warnings from buildfarm member pika. Also clean up code formatting a trifle.
-
Tom Lane authored
didn't work in EXEC_BACKEND case.
-
Simon Riggs authored
against concurrent reconnection. Failure during testing showed issue was possible, even though earlier analysis seemed to indicate it would not be required. Use LockSharedObjectForSession() before ResolveRecoveryConflictWithDatabase() and hold lock until end of processing for that WAL record. Simple approach to avoid introducing further bugs at this stage of development on an improbable issue.
-
Magnus Hagander authored
-
Peter Eisentraut authored
Mimic the Python interpreter's own logic for printing exceptions instead of just using the straight str() call, so that you get plpy.SPIError instead of <class 'plpy.SPIError'> and for built-in exceptions merely UnicodeEncodeError Besides looking better this cuts down on the endless version differences in the regression test expected files.
-
Simon Riggs authored
Noticed by Andres Freund
-
Simon Riggs authored
Conflict reason is passed through directly to the backend, so we can take decisions about the effect of the conflict based upon the local state. No specific changes, as yet, though this prepares for later work. CancelVirtualTransaction() sends signals while holding ProcArrayLock. Introduce errdetail_abort() to give message detail explaining that the abort was caused by conflict processing. Remove CONFLICT_MODE states in favour of using PROCSIG_RECOVERY_CONFLICT states directly, for clarity.
-
Tom Lane authored
the BlockSig/UnBlockSig declaration have to be PGDLLIMPORT'ified. Per buildfarm results.
-
Bruce Momjian authored
-
Tom Lane authored
-
- 15 Jan, 2010 7 commits
-
-
Tom Lane authored
parse analysis phase, rather than at execution time. This makes parameter handling work the same as it does in ordinary plannable queries, and in particular fixes the incompatibility that Pavel pointed out with plpgsql's new handling of variable references. plancache.c gets a little bit grottier, but the alternatives seem worse.
-
Tom Lane authored
-
Tom Lane authored
-
Tom Lane authored
-
Tom Lane authored
-
Heikki Linnakangas authored
process, after src/interfaces, because it depends on libpq. Also add missing lines for clean etc. targets Report from Boszormenyi Zoltan.
-
Michael Meskes authored
Added correct error handling in DESCRIBE statement processing by Boszormenyi Zoltan <zb@cybertec.at>.
-