Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
f97a028d
Commit
f97a028d
authored
Mar 14, 2017
by
Peter Eisentraut
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Spelling fixes in code comments
From: Josh Soref <jsoref@gmail.com>
parent
5ed6fff6
Changes
33
Show whitespace changes
Inline
Side-by-side
Showing
33 changed files
with
42 additions
and
42 deletions
+42
-42
contrib/pgcrypto/crypt-des.c
contrib/pgcrypto/crypt-des.c
+1
-1
contrib/spi/timetravel.c
contrib/spi/timetravel.c
+1
-1
src/backend/access/transam/twophase.c
src/backend/access/transam/twophase.c
+1
-1
src/backend/commands/copy.c
src/backend/commands/copy.c
+2
-2
src/backend/commands/tablecmds.c
src/backend/commands/tablecmds.c
+1
-1
src/backend/foreign/foreign.c
src/backend/foreign/foreign.c
+1
-1
src/backend/optimizer/plan/createplan.c
src/backend/optimizer/plan/createplan.c
+1
-1
src/backend/parser/parse_collate.c
src/backend/parser/parse_collate.c
+2
-2
src/backend/parser/parse_param.c
src/backend/parser/parse_param.c
+1
-1
src/backend/regex/regc_pg_locale.c
src/backend/regex/regc_pg_locale.c
+1
-1
src/backend/storage/ipc/procarray.c
src/backend/storage/ipc/procarray.c
+2
-2
src/backend/storage/lmgr/lock.c
src/backend/storage/lmgr/lock.c
+2
-2
src/backend/tsearch/dict_thesaurus.c
src/backend/tsearch/dict_thesaurus.c
+1
-1
src/backend/utils/adt/selfuncs.c
src/backend/utils/adt/selfuncs.c
+1
-1
src/backend/utils/cache/lsyscache.c
src/backend/utils/cache/lsyscache.c
+1
-1
src/backend/utils/cache/plancache.c
src/backend/utils/cache/plancache.c
+2
-2
src/backend/utils/error/elog.c
src/backend/utils/error/elog.c
+3
-3
src/backend/utils/fmgr/fmgr.c
src/backend/utils/fmgr/fmgr.c
+1
-1
src/backend/utils/hash/dynahash.c
src/backend/utils/hash/dynahash.c
+1
-1
src/backend/utils/misc/README
src/backend/utils/misc/README
+1
-1
src/bin/pg_dump/parallel.c
src/bin/pg_dump/parallel.c
+1
-1
src/fe_utils/string_utils.c
src/fe_utils/string_utils.c
+1
-1
src/include/utils/jsonapi.h
src/include/utils/jsonapi.h
+1
-1
src/interfaces/libpq/fe-connect.c
src/interfaces/libpq/fe-connect.c
+1
-1
src/interfaces/libpq/fe-exec.c
src/interfaces/libpq/fe-exec.c
+1
-1
src/pl/plperl/ppport.h
src/pl/plperl/ppport.h
+3
-3
src/pl/plpgsql/src/pl_exec.c
src/pl/plpgsql/src/pl_exec.c
+1
-1
src/pl/plpython/plpy_procedure.c
src/pl/plpython/plpy_procedure.c
+1
-1
src/pl/plpython/plpy_typeio.c
src/pl/plpython/plpy_typeio.c
+1
-1
src/test/regress/expected/errors.out
src/test/regress/expected/errors.out
+1
-1
src/test/regress/expected/groupingsets.out
src/test/regress/expected/groupingsets.out
+1
-1
src/test/regress/sql/errors.sql
src/test/regress/sql/errors.sql
+1
-1
src/test/regress/sql/groupingsets.sql
src/test/regress/sql/groupingsets.sql
+1
-1
No files found.
contrib/pgcrypto/crypt-des.c
View file @
f97a028d
...
...
@@ -416,7 +416,7 @@ des_setkey(const char *key)
&&
rawkey1
==
old_rawkey1
)
{
/*
* Already setup for this key. This optimi
s
ation fails on a zero key
* Already setup for this key. This optimi
z
ation fails on a zero key
* (which is weak and has bad parity anyway) in order to simplify the
* starting conditions.
*/
...
...
contrib/spi/timetravel.c
View file @
f97a028d
...
...
@@ -51,7 +51,7 @@ static EPlan *find_plan(char *ident, EPlan **eplan, int *nplans);
* and stop_date eq INFINITY [ and update_user eq current user ]
* and all other column values as in new tuple, and insert tuple
* with old data and stop_date eq current date
* ELSE - skip updati
on
of tuple.
* ELSE - skip updati
ng
of tuple.
* 2. IF a delete affects tuple with stop_date eq INFINITY
* then insert the same tuple with stop_date eq current date
* [ and delete_user eq current user ]
...
...
src/backend/access/transam/twophase.c
View file @
f97a028d
...
...
@@ -1612,7 +1612,7 @@ CheckPointTwoPhase(XLogRecPtr redo_horizon)
*
* It's also possible to move I/O out of the lock, but on every error we
* should check whether somebody committed our transaction in different
* backend. Let's leave this optimi
s
ation for future, if somebody will
* backend. Let's leave this optimi
z
ation for future, if somebody will
* spot that this place cause bottleneck.
*
* Note that it isn't possible for there to be a GXACT with a
...
...
src/backend/commands/copy.c
View file @
f97a028d
...
...
@@ -2406,7 +2406,7 @@ CopyFrom(CopyState cstate)
* earlier scan or command. This ensures that if this subtransaction
* aborts then the frozen rows won't be visible after xact cleanup. Note
* that the stronger test of exactly which subtransaction created it is
* crucial for correctness of this optimi
s
ation.
* crucial for correctness of this optimi
z
ation.
*/
if
(
cstate
->
freeze
)
{
...
...
@@ -2973,7 +2973,7 @@ BeginCopyFrom(ParseState *pstate,
* the special case of when the default expression is the
* nextval() of a sequence which in this specific case is
* known to be safe for use with the multi-insert
* optimi
s
ation. Hence we use this special case function
* optimi
z
ation. Hence we use this special case function
* checker rather than the standard check for
* contain_volatile_functions().
*/
...
...
src/backend/commands/tablecmds.c
View file @
f97a028d
...
...
@@ -3182,7 +3182,7 @@ AlterTableGetLockLevel(List *cmds)
break
;
/*
* Changing foreign table options may affect optimi
s
ation.
* Changing foreign table options may affect optimi
z
ation.
*/
case
AT_GenericOptions
:
case
AT_AlterColumnGenericOptions
:
...
...
src/backend/foreign/foreign.c
View file @
f97a028d
...
...
@@ -724,7 +724,7 @@ GetExistingLocalJoinPath(RelOptInfo *joinrel)
Path
*
path
=
(
Path
*
)
lfirst
(
lc
);
JoinPath
*
joinpath
=
NULL
;
/* Skip parameteri
s
ed paths. */
/* Skip parameteri
z
ed paths. */
if
(
path
->
param_info
!=
NULL
)
continue
;
...
...
src/backend/optimizer/plan/createplan.c
View file @
f97a028d
...
...
@@ -4582,7 +4582,7 @@ fix_indexqual_operand(Node *node, IndexOptInfo *index, int indexcol)
}
}
/* Oo
o
ps... */
/* Oops... */
elog
(
ERROR
,
"index key does not match expected index column"
);
return
NULL
;
/* keep compiler quiet */
}
...
...
src/backend/parser/parse_collate.c
View file @
f97a028d
...
...
@@ -802,7 +802,7 @@ merge_collation_state(Oid collation,
else
if
(
collation
!=
DEFAULT_COLLATION_OID
)
{
/*
* Oo
o
ps, we have a conflict. We cannot throw error
* Oops, we have a conflict. We cannot throw error
* here, since the conflict could be resolved by a
* later sibling CollateExpr, or the parent might not
* care about collation anyway. Return enough info to
...
...
@@ -821,7 +821,7 @@ merge_collation_state(Oid collation,
if
(
collation
!=
context
->
collation
)
{
/*
* Oo
o
ps, we have a conflict of explicit COLLATE clauses.
* Oops, we have a conflict of explicit COLLATE clauses.
* Here we choose to throw error immediately; that is what
* the SQL standard says to do, and there's no good reason
* to be less strict.
...
...
src/backend/parser/parse_param.c
View file @
f97a028d
...
...
@@ -210,7 +210,7 @@ variable_coerce_param_hook(ParseState *pstate, Param *param,
}
else
{
/* Oo
o
ps */
/* Oops */
ereport
(
ERROR
,
(
errcode
(
ERRCODE_AMBIGUOUS_PARAMETER
),
errmsg
(
"inconsistent types deduced for parameter $%d"
,
...
...
src/backend/regex/regc_pg_locale.c
View file @
f97a028d
...
...
@@ -224,7 +224,7 @@ static const unsigned char pg_char_properties[128] = {
* pg_set_regex_collation: set collation for these functions to obey
*
* This is called when beginning compilation or execution of a regexp.
* Since there's no need for re
-
entrancy of regexp operations, it's okay
* Since there's no need for reentrancy of regexp operations, it's okay
* to store the results in static variables.
*/
void
...
...
src/backend/storage/ipc/procarray.c
View file @
f97a028d
...
...
@@ -280,7 +280,7 @@ ProcArrayAdd(PGPROC *proc)
if
(
arrayP
->
numProcs
>=
arrayP
->
maxProcs
)
{
/*
* Oo
o
ps, no room. (This really shouldn't happen, since there is a
* Oops, no room. (This really shouldn't happen, since there is a
* fixed supply of PGPROC structs too, and so we should have failed
* earlier.)
*/
...
...
@@ -370,7 +370,7 @@ ProcArrayRemove(PGPROC *proc, TransactionId latestXid)
}
}
/* Oo
o
ps */
/* Oops */
LWLockRelease
(
ProcArrayLock
);
elog
(
LOG
,
"failed to find proc %p in ProcArray"
,
proc
);
...
...
src/backend/storage/lmgr/lock.c
View file @
f97a028d
...
...
@@ -1125,7 +1125,7 @@ SetupLockInTable(LockMethod lockMethodTable, PGPROC *proc,
&
found
);
if
(
!
proclock
)
{
/* Oo
o
ps, not enough shmem for the proclock */
/* Oops, not enough shmem for the proclock */
if
(
lock
->
nRequested
==
0
)
{
/*
...
...
@@ -4046,7 +4046,7 @@ lock_twophase_recover(TransactionId xid, uint16 info,
&
found
);
if
(
!
proclock
)
{
/* Oo
o
ps, not enough shmem for the proclock */
/* Oops, not enough shmem for the proclock */
if
(
lock
->
nRequested
==
0
)
{
/*
...
...
src/backend/tsearch/dict_thesaurus.c
View file @
f97a028d
...
...
@@ -23,7 +23,7 @@
/*
* Temporay we use TSLexeme.flags for inner use...
* Tempora
r
y we use TSLexeme.flags for inner use...
*/
#define DT_USEASIS 0x1000
...
...
src/backend/utils/adt/selfuncs.c
View file @
f97a028d
...
...
@@ -4312,7 +4312,7 @@ get_restriction_variable(PlannerInfo *root, List *args, int varRelid,
return
true
;
}
/* Oo
o
ps, clause has wrong structure (probably var op var) */
/* Oops, clause has wrong structure (probably var op var) */
ReleaseVariableStats
(
*
vardata
);
ReleaseVariableStats
(
rdata
);
...
...
src/backend/utils/cache/lsyscache.c
View file @
f97a028d
...
...
@@ -2332,7 +2332,7 @@ get_typavgwidth(Oid typid, int32 typmod)
}
/*
* Oo
o
ps, we have no idea ... wild guess time.
* Oops, we have no idea ... wild guess time.
*/
return
32
;
}
...
...
src/backend/utils/cache/plancache.c
View file @
f97a028d
...
...
@@ -621,7 +621,7 @@ RevalidateCachedQuery(CachedPlanSource *plansource)
return
NIL
;
}
/* Oo
o
ps, the race case happened. Release useless locks. */
/* Oops, the race case happened. Release useless locks. */
AcquirePlannerLocks
(
plansource
->
query_list
,
false
);
}
...
...
@@ -845,7 +845,7 @@ CheckCachedPlan(CachedPlanSource *plansource)
return
true
;
}
/* Oo
o
ps, the race case happened. Release useless locks. */
/* Oops, the race case happened. Release useless locks. */
AcquireExecutorLocks
(
plan
->
stmt_list
,
false
);
}
...
...
src/backend/utils/error/elog.c
View file @
f97a028d
...
...
@@ -318,7 +318,7 @@ errstart(int elevel, const char *filename, int lineno,
*/
if
(
ErrorContext
==
NULL
)
{
/* Oo
o
ps, hard crash time; very little we can do safely here */
/* Oops, hard crash time; very little we can do safely here */
write_stderr
(
"error occurred at %s:%d before error message processing is available
\n
"
,
filename
?
filename
:
"(unknown file)"
,
lineno
);
exit
(
2
);
...
...
@@ -331,7 +331,7 @@ errstart(int elevel, const char *filename, int lineno,
if
(
recursion_depth
++
>
0
&&
elevel
>=
ERROR
)
{
/*
* Oo
o
ps, error during error processing. Clear ErrorContext as
* Oops, error during error processing. Clear ErrorContext as
* discussed at top of file. We will not return to the original
* error's reporter or handler, so we don't need it.
*/
...
...
@@ -1302,7 +1302,7 @@ elog_start(const char *filename, int lineno, const char *funcname)
/* Make sure that memory context initialization has finished */
if
(
ErrorContext
==
NULL
)
{
/* Oo
o
ps, hard crash time; very little we can do safely here */
/* Oops, hard crash time; very little we can do safely here */
write_stderr
(
"error occurred at %s:%d before error message processing is available
\n
"
,
filename
?
filename
:
"(unknown file)"
,
lineno
);
exit
(
2
);
...
...
src/backend/utils/fmgr/fmgr.c
View file @
f97a028d
...
...
@@ -877,7 +877,7 @@ struct fmgr_security_definer_cache
* To execute a call, we temporarily replace the flinfo with the cached
* and looked-up one, while keeping the outer fcinfo (which contains all
* the actual arguments, etc.) intact. This is not re-entrant, but then
* the fcinfo itself can't be used re
-
entrantly anyway.
* the fcinfo itself can't be used reentrantly anyway.
*/
static
Datum
fmgr_security_definer
(
PG_FUNCTION_ARGS
)
...
...
src/backend/utils/hash/dynahash.c
View file @
f97a028d
...
...
@@ -72,7 +72,7 @@
* when combined with HASH_DEBUG, these are displayed by hdestroy().
*
* Problems & fixes to ejp@ausmelb.oz. WARNING: relies on pre-processor
* concatenation property, in probably unnecessary code 'optimi
s
ation'.
* concatenation property, in probably unnecessary code 'optimi
z
ation'.
*
* Modified margo@postgres.berkeley.edu February 1990
* added multiple table interface
...
...
src/backend/utils/misc/README
View file @
f97a028d
...
...
@@ -114,7 +114,7 @@ If a show_hook is provided, it points to a function of the signature
This hook allows variable-specific computation of the value displayed
by SHOW (and other SQL features for showing GUC variable values).
The return value can point to a static buffer, since show functions are
not used re
-
entrantly.
not used reentrantly.
Saving/Restoring GUC Variable Values
...
...
src/bin/pg_dump/parallel.c
View file @
f97a028d
...
...
@@ -92,7 +92,7 @@ struct ParallelSlot
/* These fields are valid if workerStatus == WRKR_WORKING: */
ParallelCompletionPtr
callback
;
/* function to call on completion */
void
*
callback_data
;
/* passthr
u
data for it */
void
*
callback_data
;
/* passthr
ough
data for it */
ArchiveHandle
*
AH
;
/* Archive data worker is using */
...
...
src/fe_utils/string_utils.c
View file @
f97a028d
...
...
@@ -173,7 +173,7 @@ fmtQualifiedId(int remoteVersion, const char *schema, const char *id)
* returned by PQserverVersion()) as a string. This exists mainly to
* encapsulate knowledge about two-part vs. three-part version numbers.
*
* For re
-
entrancy, caller must supply the buffer the string is put in.
* For reentrancy, caller must supply the buffer the string is put in.
* Recommended size of the buffer is 32 bytes.
*
* Returns address of 'buf', as a notational convenience.
...
...
src/include/utils/jsonapi.h
View file @
f97a028d
...
...
@@ -127,7 +127,7 @@ extern JsonLexContext *makeJsonLexContextCstringLen(char *json,
/*
* Utility function to check if a string is a valid JSON number.
*
* str a
gr
ument does not need to be nul-terminated.
* str a
rg
ument does not need to be nul-terminated.
*/
extern
bool
IsValidJsonNumber
(
const
char
*
str
,
int
len
);
...
...
src/interfaces/libpq/fe-connect.c
View file @
f97a028d
...
...
@@ -2136,7 +2136,7 @@ keep_going: /* We will come back to here until there is
}
/* loop over addresses */
/*
* Oo
o
ps, no more addresses. An appropriate error message is
* Oops, no more addresses. An appropriate error message is
* already set up, so just set the right status.
*/
goto
error_return
;
...
...
src/interfaces/libpq/fe-exec.c
View file @
f97a028d
...
...
@@ -2334,7 +2334,7 @@ PQputCopyEnd(PGconn *conn, const char *errormsg)
{
if
(
errormsg
)
{
/* Oo
o
ps, no way to do this in 2.0 */
/* Oops, no way to do this in 2.0 */
printfPQExpBuffer
(
&
conn
->
errorMessage
,
libpq_gettext
(
"function requires at least protocol version 3.0
\n
"
));
return
-
1
;
...
...
src/pl/plperl/ppport.h
View file @
f97a028d
...
...
@@ -6205,10 +6205,10 @@ DPPP_(my_grok_number)(pTHX_ const char *pv, STRLEN len, UV *valuep)
/* UVs are at least 32 bits, so the first 9 decimal digits cannot
overflow. */
UV
value
=
*
s
-
'0'
;
/* This construction seems to be more optimi
s
er friendly.
/* This construction seems to be more optimi
z
er friendly.
(without it gcc does the isDIGIT test and the *s - '0' separately)
With it gcc on arm is managing 6 instructions (6 cycles) per digit.
In theory the optimi
s
er could deduce how far to unroll the loop
In theory the optimi
z
er could deduce how far to unroll the loop
before checking for overflow. */
if
(
++
s
<
send
)
{
int
digit
=
*
s
-
'0'
;
...
...
@@ -6606,7 +6606,7 @@ DPPP_(my_grok_oct)(pTHX_ const char *start, STRLEN *len_p, I32 *flags, NV *resul
bool
overflowed
=
FALSE
;
for
(;
len
--
&&
*
s
;
s
++
)
{
/* gcc 2.95 optimi
s
er not smart enough to figure that this subtraction
/* gcc 2.95 optimi
z
er not smart enough to figure that this subtraction
out front allows slicker code. */
int
digit
=
*
s
-
'0'
;
if
(
digit
>=
0
&&
digit
<=
7
)
{
...
...
src/pl/plpgsql/src/pl_exec.c
View file @
f97a028d
...
...
@@ -5543,7 +5543,7 @@ exec_eval_simple_expr(PLpgSQL_execstate *estate,
exec_check_rw_parameter
(
expr
,
expr
->
rwparam
);
if
(
expr
->
expr_simple_expr
==
NULL
)
{
/* Oo
o
ps, release refcount and fail */
/* Oops, release refcount and fail */
ReleaseCachedPlan
(
cplan
,
true
);
return
false
;
}
...
...
src/pl/plpython/plpy_procedure.c
View file @
f97a028d
...
...
@@ -122,7 +122,7 @@ PLy_procedure_get(Oid fn_oid, Oid fn_rel, bool is_trigger)
}
PG_CATCH
();
{
/* Do not leave an uninitiali
s
ed entry in the cache */
/* Do not leave an uninitiali
z
ed entry in the cache */
if
(
use_cache
)
hash_search
(
PLy_procedure_cache
,
&
key
,
HASH_REMOVE
,
NULL
);
PG_RE_THROW
();
...
...
src/pl/plpython/plpy_typeio.c
View file @
f97a028d
...
...
@@ -827,7 +827,7 @@ PLyObject_ToComposite(PLyObToDatum *arg, int32 typmod, PyObject *plrv, bool inar
/*
* This will set up the dummy PLyTypeInfo's output conversion routines,
* since we left is_rowtype as 2. A future optimi
s
ation could be caching
* since we left is_rowtype as 2. A future optimi
z
ation could be caching
* that info instead of looking it up every time a tuple is returned from
* the function.
*/
...
...
src/test/regress/expected/errors.out
View file @
f97a028d
--
-- ERRORS
--
-- bad in postquel, but ok in
postsql
-- bad in postquel, but ok in
PostgreSQL
select 1;
?column?
----------
...
...
src/test/regress/expected/groupingsets.out
View file @
f97a028d
...
...
@@ -375,7 +375,7 @@ select *
ERROR: aggregate functions are not allowed in FROM clause of their own query level
LINE 3: lateral (select a, b, sum(v.x) from gstest_data(v.x) ...
^
-- min max optimi
s
ation should still work with GROUP BY ()
-- min max optimi
z
ation should still work with GROUP BY ()
explain (costs off)
select min(unique1) from tenk1 GROUP BY ();
QUERY PLAN
...
...
src/test/regress/sql/errors.sql
View file @
f97a028d
...
...
@@ -2,7 +2,7 @@
-- ERRORS
--
-- bad in postquel, but ok in
postsql
-- bad in postquel, but ok in
PostgreSQL
select
1
;
...
...
src/test/regress/sql/groupingsets.sql
View file @
f97a028d
...
...
@@ -140,7 +140,7 @@ select *
from
(
values
(
1
),(
2
))
v
(
x
),
lateral
(
select
a
,
b
,
sum
(
v
.
x
)
from
gstest_data
(
v
.
x
)
group
by
rollup
(
a
,
b
))
s
;
-- min max optimi
s
ation should still work with GROUP BY ()
-- min max optimi
z
ation should still work with GROUP BY ()
explain
(
costs
off
)
select
min
(
unique1
)
from
tenk1
GROUP
BY
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment