Commit f7d7ac23 authored by Thomas Munro's avatar Thomas Munro

Fix overly generic name in with.sql test.

Avoid the name "test".  In the 10 branch, this could clash with
alter_table.sql, as seen in the build farm.  That other instance was
already renamed in later branches by commit 2cf8c7aa, but it's good to
future-proof the name here too.

Back-patch to 10.
Reviewed-by: default avatarTom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CA%2BhUKGJf4RAXUyAYVUcQawcptX%3DnhEco3SYpuPK5cCbA-F1eLA%40mail.gmail.com
parent 2ff20995
...@@ -3118,19 +3118,19 @@ with ordinality as (select 1 as x) select * from ordinality; ...@@ -3118,19 +3118,19 @@ with ordinality as (select 1 as x) select * from ordinality;
(1 row) (1 row)
-- check sane response to attempt to modify CTE relation -- check sane response to attempt to modify CTE relation
WITH test AS (SELECT 42) INSERT INTO test VALUES (1); WITH with_test AS (SELECT 42) INSERT INTO with_test VALUES (1);
ERROR: relation "test" does not exist ERROR: relation "with_test" does not exist
LINE 1: WITH test AS (SELECT 42) INSERT INTO test VALUES (1); LINE 1: WITH with_test AS (SELECT 42) INSERT INTO with_test VALUES (...
^ ^
-- check response to attempt to modify table with same name as a CTE (perhaps -- check response to attempt to modify table with same name as a CTE (perhaps
-- surprisingly it works, because CTEs don't hide tables from data-modifying -- surprisingly it works, because CTEs don't hide tables from data-modifying
-- statements) -- statements)
create temp table test (i int); create temp table with_test (i int);
with test as (select 42) insert into test select * from test; with with_test as (select 42) insert into with_test select * from with_test;
select * from test; select * from with_test;
i i
---- ----
42 42
(1 row) (1 row)
drop table test; drop table with_test;
...@@ -1451,12 +1451,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word ...@@ -1451,12 +1451,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word
with ordinality as (select 1 as x) select * from ordinality; with ordinality as (select 1 as x) select * from ordinality;
-- check sane response to attempt to modify CTE relation -- check sane response to attempt to modify CTE relation
WITH test AS (SELECT 42) INSERT INTO test VALUES (1); WITH with_test AS (SELECT 42) INSERT INTO with_test VALUES (1);
-- check response to attempt to modify table with same name as a CTE (perhaps -- check response to attempt to modify table with same name as a CTE (perhaps
-- surprisingly it works, because CTEs don't hide tables from data-modifying -- surprisingly it works, because CTEs don't hide tables from data-modifying
-- statements) -- statements)
create temp table test (i int); create temp table with_test (i int);
with test as (select 42) insert into test select * from test; with with_test as (select 42) insert into with_test select * from with_test;
select * from test; select * from with_test;
drop table test; drop table with_test;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment