Commit f7b711c8 authored by Robert Haas's avatar Robert Haas

Cosmetic fixes for hash index write-ahead logging.

Amit Kapila.  One of these was reported by Tom Lane.

Discussion: http://postgr.es/m/5515.1489514099@sss.pgh.pa.us
parent aefeb687
...@@ -365,9 +365,6 @@ try to split the bucket again until the prior split is finished. In other ...@@ -365,9 +365,6 @@ try to split the bucket again until the prior split is finished. In other
words, a bucket can be in the middle of being split for some time, but it can't words, a bucket can be in the middle of being split for some time, but it can't
be in the middle of two splits at the same time. be in the middle of two splits at the same time.
Although we can survive a failure to split a bucket, a crash is likely to
corrupt the index, since hash indexes are not yet WAL-logged.
The fourth operation is garbage collection (bulk deletion): The fourth operation is garbage collection (bulk deletion):
next bucket := 0 next bucket := 0
......
...@@ -975,7 +975,7 @@ fail: ...@@ -975,7 +975,7 @@ fail:
* hash indexes sequentially anyway, that probably doesn't matter. * hash indexes sequentially anyway, that probably doesn't matter.
* *
* XXX It's annoying that this code is executed with the metapage lock held. * XXX It's annoying that this code is executed with the metapage lock held.
* We need to interlock against _hash_getovflpage() adding a new overflow page * We need to interlock against _hash_addovflpage() adding a new overflow page
* concurrently, but it'd likely be better to use LockRelationForExtension * concurrently, but it'd likely be better to use LockRelationForExtension
* for the purpose. OTOH, adding a splitpoint is a very infrequent operation, * for the purpose. OTOH, adding a splitpoint is a very infrequent operation,
* so it may not be worth worrying about. * so it may not be worth worrying about.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment